Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Mikhail Rudenko <mike.rudenko@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 0/4] Fix KernelShark appearance on dark color schemes
Date: Fri, 11 Oct 2019 17:11:38 +0300
Message-ID: <9a5c1135-12b9-27c2-159a-7468b0877650@gmail.com> (raw)
In-Reply-To: <20191010180205.06aab874@gandalf.local.home>



On 11.10.19 г. 1:02 ч., Steven Rostedt wrote:
> On Fri, 11 Oct 2019 00:24:25 +0300
> Mikhail Rudenko <mike.rudenko@gmail.com> wrote:
> 
>> Currently a few widgets in Kernel Shark UI use custom stylesheets,
>> unconditionally setting their background or text color (but not both!)
>> to hard-coded values. This has a side effect of widget text being
>> poorly readable on some color schemes (e.g. Breeze Dark, and dark
>> schemes in general). This patch series tries to address this issue.
>>
>> The first three patches are trivial: they ensure that whenever the
>> background color of a widget is set to white via stylesheet, its text
>> color is set to black.
>>
>> The fourth one changes "inactive" marker selection button style to
>> system default, making it look clickable on all color schemes.
>>
>> Mikhail Rudenko (4):
>>    kernel-shark: Set text color to black in KsDualMarker's QLabels
>>    kernel-shark: Set text color to black in pointer position QLabel
>>    kernel-shark: Set text color to black in KsTraceGraph's axes labels
>>    kernel-shark: Change KsDualMarker's inactive button style to default
>>
>>   kernel-shark/src/KsDualMarker.cpp | 11 ++---------
>>   kernel-shark/src/KsTraceGraph.cpp |  6 ++++--
>>   2 files changed, 6 insertions(+), 11 deletions(-)
> 
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Yordan,
> 
> If you are fine with these patches, could you pull them in and push
> them to the repo?

Hi Mikhail,

Thanks a lot!
I am pushing the patches.
Is is possible to send us a screenshot? I am curious to see how 
KernelShark looks on your dark color scheme.

cheers,
Yordan

> 
> -- Steve
> 

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 21:24 Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 1/4] kernel-shark: Set text color to black in KsDualMarker's QLabels Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 2/4] kernel-shark: Set text color to black in pointer position QLabel Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 3/4] kernel-shark: Set text color to black in KsTraceGraph's axes labels Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 4/4] kernel-shark: Change KsDualMarker's inactive button style to default Mikhail Rudenko
2019-10-10 22:02 ` [PATCH 0/4] Fix KernelShark appearance on dark color schemes Steven Rostedt
2019-10-11 14:11   ` Yordan Karadzhov (VMware) [this message]
2019-10-11 18:18     ` Mikhail Rudenko

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a5c1135-12b9-27c2-159a-7468b0877650@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mike.rudenko@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git