Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
	Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v12 1/9] trace-cmd: Implemented new lib API: tracecmd_local_events_system()
Date: Fri, 25 Oct 2019 09:24:56 +0000
Message-ID: <CACqStodH0c_3FuH5L64ywid1coRE90H6gEGJr6uA03nxh1D15A@mail.gmail.com> (raw)
In-Reply-To: <20191022123401.4e2b1ab6@gandalf.local.home>

On Tue, Oct 22, 2019 at 7:34 PM Steven Rostedt <rostedt@goodmis.org> wrote:
...
> > +{
> > +     return tracecmd_fill_local_events_system(tracing_dir, pevent,
> > +                                              NULL, parsing_failures);
>
> Won't this return no events?
>
> -- Steve
>
Looks like it will return no events, I'll review the logic and the patch.

> > +}
> > +
> >  /**
> >   * tracecmd_local_plugins - returns an array of available tracer plugins
> >   * @tracing_dir: The directory that contains the tracing directory
>


-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  8:57 [PATCH v12 0/9] trace-cmd: Timetamps sync between host and guest machines, relying on vsock events Tzvetomir Stoyanov (VMware)
2019-08-28  8:57 ` [PATCH v12 1/9] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov (VMware)
2019-10-22 16:34   ` Steven Rostedt
2019-10-25  9:24     ` Tzvetomir Stoyanov [this message]
2019-08-28  8:57 ` [PATCH v12 2/9] trace-cmd: Added support for negative time offsets in trace.dat file Tzvetomir Stoyanov (VMware)
2019-08-28  8:57 ` [PATCH v12 3/9] trace-cmd: Fix tracecmd_read_page_record() to read more than one event Tzvetomir Stoyanov (VMware)
2019-10-22 17:34   ` Steven Rostedt
2019-08-28  8:57 ` [PATCH v12 4/9] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov (VMware)
2019-08-28  8:57 ` [PATCH v12 5/9] trace-cmd: Refactored few functions in trace-record.c Tzvetomir Stoyanov (VMware)
2019-10-22 17:47   ` Steven Rostedt
2019-08-28  8:57 ` [PATCH v12 6/9] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov (VMware)
2019-08-28  8:57 ` [PATCH v12 7/9] trace-cmd: Implemented new API tracecmd_add_option_v() Tzvetomir Stoyanov (VMware)
2019-10-22 19:10   ` Steven Rostedt
2019-08-28  8:57 ` [PATCH v12 8/9] trace-cmd: Implemented new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov (VMware)
2019-08-28  8:57 ` [PATCH v12 9/9] trace-cmd [POC]: Implemented timestamps synch algorithm, using vsock events Tzvetomir Stoyanov (VMware)

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACqStodH0c_3FuH5L64ywid1coRE90H6gEGJr6uA03nxh1D15A@mail.gmail.com \
    --to=tstoyanov@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git