From: Slavomir Kaslev <kaslevs@vmware.com>
To: "rostedt@goodmis.org" <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/2] trace-cmd: Bump protocol version to v3
Date: Mon, 3 Dec 2018 16:32:50 +0000 [thread overview]
Message-ID: <CAE0o1NuZ+BAfUmYmNU=-b0=mp3LYYN3LjBWZby=nLT=1T2s2BQ@mail.gmail.com> (raw)
In-Reply-To: <20181203111804.717abf40@vmware.local.home>
On Mon, Dec 3, 2018 at 6:19 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 3 Dec 2018 18:09:36 +0200
> Slavomir Kaslev <kaslevs@vmware.com> wrote:
>
> > This patch bumps trace-cmd protocol to v3 while keeping backward compatibility
> > by falling back to v1.
> >
> > The new protocol works similarly to v2 but allows future extension of commands
> > by saving the command size on the wire and having the client on the other side
> > to only read the bits it understands.
> >
>
> So is this a V3 that is ready for prime time?
>
> That is, you are happy with the protocol and that old code will work
> with the new (as we talked about before).
Yes, I'm happy it. It allows us to add fields to our current commands
in the future and should be backward and forward compatible.
I will resend the vsock patch rebased after those two patches get
reviewed and merged.
--
Slavi
next prev parent reply other threads:[~2018-12-03 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 16:09 [PATCH 0/2] trace-cmd: Resend record --date fix Slavomir Kaslev
2018-12-03 16:09 ` [PATCH 1/2] trace-cmd: Bump protocol version to v3 Slavomir Kaslev
2018-12-03 16:18 ` Steven Rostedt
2018-12-03 16:32 ` Slavomir Kaslev [this message]
2018-12-03 16:09 ` [PATCH 2/2] trace-cmd: Fix record --date flag when sending tracing data to a listener Slavomir Kaslev
2018-12-04 22:34 ` [PATCH 0/2] trace-cmd: Resend record --date fix Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE0o1NuZ+BAfUmYmNU=-b0=mp3LYYN3LjBWZby=nLT=1T2s2BQ@mail.gmail.com' \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).