From: Slavomir Kaslev <slavomir.kaslev@gmail.com>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: "rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 0/5] trace-cmd reset fixes
Date: Tue, 5 Mar 2019 15:24:20 +0200 [thread overview]
Message-ID: <CAE0o1NvxSaArhDO5W96tdy7AGDVOp8OTSFgDY_o6gP1Ga3tirw@mail.gmail.com> (raw)
In-Reply-To: <20181213142125.12149-1-tstoyanov@vmware.com>
On Thu, Dec 13, 2018 at 4:22 PM Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
>
> This patch series fixes "trace-cmd reset" command to
> restore default values of various ftrace configurations:
> tracng_on, trace_clock, set_event_pid and tracing_max_latency.
> It also fixes a segfault when the command is executed with
> "-a -d" options.
>
> Tzvetomir Stoyanov (5):
> fix "trace-cmd reset" command to restore "tracng_on"
> fix "trace-cmd reset -a -d" segfault
> fix "trace-cmd reset" command to restore default clock
> fix "trace-cmd reset" command to restore the default value of
> set_event_pid
> fix "trace-cmd reset" command to restore the default value of
> tracing_max_latency
>
> tracecmd/trace-record.c | 37 ++++++++++++++++++++++++++++++++++---
> 1 file changed, 34 insertions(+), 3 deletions(-)
All 5 patches seems good to me
Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
Thank you,
-- Slavi
prev parent reply other threads:[~2019-03-05 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 14:21 [PATCH 0/5] trace-cmd reset fixes Tzvetomir Stoyanov
2018-12-13 14:21 ` [PATCH 1/5] fix "trace-cmd reset" command to restore "tracng_on" Tzvetomir Stoyanov
2018-12-13 14:21 ` [PATCH 2/5] fix "trace-cmd reset -a -d" segfault Tzvetomir Stoyanov
2018-12-13 14:21 ` [PATCH 3/5] fix "trace-cmd reset" command to restore default clock Tzvetomir Stoyanov
2018-12-13 14:21 ` [PATCH 4/5] fix "trace-cmd reset" command to restore the default value of set_event_pid Tzvetomir Stoyanov
2019-03-05 19:03 ` Steven Rostedt
2018-12-13 14:21 ` [PATCH 5/5] fix "trace-cmd reset" command to restore the default value of tracing_max_latency Tzvetomir Stoyanov
2019-03-05 19:06 ` Steven Rostedt
2019-03-05 13:24 ` Slavomir Kaslev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE0o1NvxSaArhDO5W96tdy7AGDVOp8OTSFgDY_o6gP1Ga3tirw@mail.gmail.com \
--to=slavomir.kaslev@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).