From: Daniel Colascione <dancol@google.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
atish patra <atishp04@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Karim Yaghmour <karim.yaghmour@opersys.com>,
Kees Cook <keescook@chromium.org>,
"Cc: Android Kernel" <kernel-team@android.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-trace-devel@vger.kernel.org,
Manoj Rao <linux@manojrajarao.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Qais Yousef <qais.yousef@arm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH v6 1/2] Provide in-kernel headers to make extending kernel easier
Date: Fri, 12 Apr 2019 18:52:22 -0700 [thread overview]
Message-ID: <CAKOZueuf8qM1O7c+m7zRHv1b6-YsZmWoTBfErBLY+yV1pyESmQ@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAT83SijpivFJA8GS=bOsgfnV03fo+-QJFgO1SgmLBOiQw@mail.gmail.com>
On Fri, Apr 12, 2019 at 6:49 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Sat, Apr 13, 2019 at 3:02 AM Joel Fernandes <joel@joelfernandes.org> wrote:
>
> >
> > > > +extern char kernel_headers_data;
> > > > +extern char kernel_headers_data_end;
> > > > +
> > > > +static ssize_t
> > > > +ikheaders_read_current(struct file *file, char __user *buf,
> > >
> > > Could you stretch this line ?
> > > It will still fit in 80-cols.
> > >
> > > (This is a coding style error in kernel/configs.c)
> >
> > It takes 87 cols if I expand, so I'll leave it as is.
> >
>
>
> Sorry if what I said was unclear.
>
> Since I just did not a good reason to put
> "static ssize_t" in the previous line,
> I meant like follows:
>
>
> [Before]
> static ssize_t
> ikheaders_read_current(struct file *file, char __user *buf,
> size_t len, loff_t *offset)
>
>
>
> [After]
> static ssize_t ikheaders_read_current(struct file *file, char __user *buf,
> size_t len, loff_t *offset)
>
>
> (takes 74-cols.)
>
>
> (I am sending this from Gmail, so I am not sure
> how it will look like from you...)
>
>
> Anyway, it is super-bikeshedding stuff.
> It is OK as-is.
>
What about sorting the files for determinism?
next prev parent reply other threads:[~2019-04-13 1:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 21:28 [PATCH v6 1/2] Provide in-kernel headers to make extending kernel easier Joel Fernandes (Google)
2019-04-08 21:28 ` [PATCH v6 2/2] init/config: Do not select BUILD_BIN2C for IKCONFIG Joel Fernandes (Google)
2019-04-11 14:17 ` Masahiro Yamada
2019-04-09 15:00 ` [PATCH v6 1/2] Provide in-kernel headers to make extending kernel easier Qais Yousef
2019-04-09 15:11 ` Joel Fernandes
2019-04-11 1:47 ` Masahiro Yamada
2019-04-12 18:00 ` Joel Fernandes
2019-04-13 1:48 ` Masahiro Yamada
2019-04-13 1:52 ` Daniel Colascione [this message]
2019-04-13 2:58 ` Masahiro Yamada
2019-04-13 3:09 ` Masahiro Yamada
2019-04-13 3:18 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOZueuf8qM1O7c+m7zRHv1b6-YsZmWoTBfErBLY+yV1pyESmQ@mail.gmail.com \
--to=dancol@google.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=atishp04@gmail.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=joel@joelfernandes.org \
--cc=karim.yaghmour@opersys.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux@manojrajarao.com \
--cc=mhiramat@kernel.org \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).