Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* Getting libtraceevent into a packaged library
@ 2019-10-03 19:01 Steven Rostedt
  2019-10-03 19:22 ` Tony Jones
  2019-10-04  2:51 ` Namhyung Kim
  0 siblings, 2 replies; 5+ messages in thread
From: Steven Rostedt @ 2019-10-03 19:01 UTC (permalink / raw)
  To: Patrick McLean, John Kacur, Alan Mikhak, Seth Forshee,
	Tony Jones, Linux Trace Devel, Mauro Carvalho Chehab,
	Namhyung Kim, Nivedita Swaminathan

Hello folks,

I've Cc'd everyone that might be interested in helping package
libtraceveent. It is basically ready to become a full library package.
I only have a couple of patches to deal with SPDX headers and such, but
other than that, I think we are good to go.

My question is now, how to we go about having distributions package it.
Like perf, the main source code lives in the Linux kernel source tree
under:

 tools/lib/traceevent

I'd like to install the following headers in /usr/include

  event-parse.h
  kbuffer.h
  trace-seq.h

And the following libraries:

  libtraceevent.so (with all its versions)

Documentation man pages are in the Documentation directory.

And we should have plugins installed as well.

If we had done everything correctly, a "make install" in that directory
will move all the files to their proper location.

make doc will create the man pages.

make doc-install will install the man pages.

What's the next step to get this into a package so that perf,
trace-cmd, power-top, rasdaemon, uftrace, and whatever does not need to
have its own copy of the code, but instead link to it.

Note, the interface has changed since other tools copied it, and I'm
willing to help anyone out in porting to the package.

Let me know of anyone else that can help in getting this packaged for a
Linux distribution.

-- Steve

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Getting libtraceevent into a packaged library
  2019-10-03 19:01 Getting libtraceevent into a packaged library Steven Rostedt
@ 2019-10-03 19:22 ` Tony Jones
  2019-10-04  2:51 ` Namhyung Kim
  1 sibling, 0 replies; 5+ messages in thread
From: Tony Jones @ 2019-10-03 19:22 UTC (permalink / raw)
  To: Steven Rostedt, Patrick McLean, John Kacur, Alan Mikhak,
	Seth Forshee, Linux Trace Devel, Mauro Carvalho Chehab,
	Namhyung Kim, Nivedita Swaminathan

On 10/3/19 12:01 PM, Steven Rostedt wrote:

> My question is now, how to we go about having distributions package it.
> Like perf, the main source code lives in the Linux kernel source tree
> under:
> 
>   tools/lib/traceevent

We're happy to look into this.

> What's the next step to get this into a package so that perf,
> trace-cmd, power-top, rasdaemon, uftrace, and whatever does not need to
> have its own copy of the code, but instead link to it.

If building perf from source (git) it would be useful to be able to select either the lib/traceevent in the tree (probably
should be the default) or the libtraceevent installed via rpm/etc.   Obviously the later is a pre-requisite to being able
to package perf with a rpm build-requires on the libtraceevent-devel rpm.

> Let me know of anyone else that can help in getting this packaged for a
> Linux distribution.

Tony


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Getting libtraceevent into a packaged library
  2019-10-03 19:01 Getting libtraceevent into a packaged library Steven Rostedt
  2019-10-03 19:22 ` Tony Jones
@ 2019-10-04  2:51 ` Namhyung Kim
  2019-10-04 13:33   ` Steven Rostedt
  1 sibling, 1 reply; 5+ messages in thread
From: Namhyung Kim @ 2019-10-04  2:51 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Patrick McLean, John Kacur, Alan Mikhak, Seth Forshee,
	Tony Jones, Linux Trace Devel, Mauro Carvalho Chehab,
	Nivedita Swaminathan

Hi Steve,

On Fri, Oct 4, 2019 at 4:01 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> What's the next step to get this into a package so that perf,
> trace-cmd, power-top, rasdaemon, uftrace, and whatever does not need to
> have its own copy of the code, but instead link to it.
>
> Note, the interface has changed since other tools copied it, and I'm
> willing to help anyone out in porting to the package.

For uftrace, I think it needs to keep the copy of the code for a while
since it should support older versions of distros as well.
I'll add a runtime dependency check for libtraceevent and use
the new APIs if exists.

Thanks,
Namhyung

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Getting libtraceevent into a packaged library
  2019-10-04  2:51 ` Namhyung Kim
@ 2019-10-04 13:33   ` Steven Rostedt
  2019-10-06 14:15     ` Namhyung Kim
  0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2019-10-04 13:33 UTC (permalink / raw)
  To: Namhyung Kim
  Cc: Patrick McLean, John Kacur, Alan Mikhak, Seth Forshee,
	Tony Jones, Linux Trace Devel, Mauro Carvalho Chehab,
	Nivedita Swaminathan

On Fri, 4 Oct 2019 11:51:12 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> Hi Steve,
> 
> On Fri, Oct 4, 2019 at 4:01 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> > What's the next step to get this into a package so that perf,
> > trace-cmd, power-top, rasdaemon, uftrace, and whatever does not need to
> > have its own copy of the code, but instead link to it.
> >
> > Note, the interface has changed since other tools copied it, and I'm
> > willing to help anyone out in porting to the package.  
> 
> For uftrace, I think it needs to keep the copy of the code for a while
> since it should support older versions of distros as well.
> I'll add a runtime dependency check for libtraceevent and use
> the new APIs if exists.
> 

What do you mean by support older distros? You mean older distros
not having the library (a user could always just download the source
code and compile it themselves :-) Or handling the trace events,
because libtraceevent should be able to handle older kernels.

-- Steve

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Getting libtraceevent into a packaged library
  2019-10-04 13:33   ` Steven Rostedt
@ 2019-10-06 14:15     ` Namhyung Kim
  0 siblings, 0 replies; 5+ messages in thread
From: Namhyung Kim @ 2019-10-06 14:15 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Patrick McLean, John Kacur, Alan Mikhak, Seth Forshee,
	Tony Jones, Linux Trace Devel, Mauro Carvalho Chehab,
	Nivedita Swaminathan

Hi Steve,

On Fri, Oct 4, 2019 at 10:33 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 4 Oct 2019 11:51:12 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>
> > Hi Steve,
> >
> > On Fri, Oct 4, 2019 at 4:01 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> > > What's the next step to get this into a package so that perf,
> > > trace-cmd, power-top, rasdaemon, uftrace, and whatever does not need to
> > > have its own copy of the code, but instead link to it.
> > >
> > > Note, the interface has changed since other tools copied it, and I'm
> > > willing to help anyone out in porting to the package.
> >
> > For uftrace, I think it needs to keep the copy of the code for a while
> > since it should support older versions of distros as well.
> > I'll add a runtime dependency check for libtraceevent and use
> > the new APIs if exists.
> >
>
> What do you mean by support older distros? You mean older distros
> not having the library (a user could always just download the source
> code and compile it themselves :-) Or handling the trace events,
> because libtraceevent should be able to handle older kernels.

Oh, I meant the former.

Thanks
Namhyung

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 19:01 Getting libtraceevent into a packaged library Steven Rostedt
2019-10-03 19:22 ` Tony Jones
2019-10-04  2:51 ` Namhyung Kim
2019-10-04 13:33   ` Steven Rostedt
2019-10-06 14:15     ` Namhyung Kim

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox