From: Khem Raj <raj.khem@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] Replace LFS64 interfaces off64_t and lseek64
Date: Mon, 9 Jan 2023 17:03:21 -0800 [thread overview]
Message-ID: <CAMKF1sr9Jp97_NrvPuONjFiULHdnz0AJuBGcigJvHQcYe12o4Q@mail.gmail.com> (raw)
In-Reply-To: <20230109185100.7b0cf697@gandalf.local.home>
On Mon, Jan 9, 2023 at 3:51 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 9 Jan 2023 14:53:14 -0800
> Khem Raj <raj.khem@gmail.com> wrote:
>
> > Musl does not define these interfaces unless -D_LARGEFILE64_SOURCE is
> > defined and that too it is transitional until apps switch to using 64-bit
> > off_t. We pass -D_FILE_OFFSET_BITS=64 in makefiles already therefore
> > original lseek and off_t are already 64bit
> >
> > This fixes build with latest musl which has dropped LFS64 interfaces [1]
> >
> > [1] https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4i
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
>
> FYI, when submitting patches, please have the subject state the project, as
> the mailing list covers multiple projects, and the subjects are used to
> determine which project its for.
>
> Subject: trace-cmd: Replace LFS64 interfaces off64_t and lseek64
>
> You don't need to resubmit, I can add it, but just for future submissions.
>
Understood. Somehow it did not occur to me my bad :(. will keep in
mind next time.
> Thanks!
>
> -- Steve
prev parent reply other threads:[~2023-01-10 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:53 [PATCH 1/2] Replace LFS64 interfaces off64_t and lseek64 Khem Raj
2023-01-09 22:53 ` [PATCH 2/2] Drop using _LARGEFILE64_SOURCE Khem Raj
2023-01-09 23:51 ` [PATCH 1/2] Replace LFS64 interfaces off64_t and lseek64 Steven Rostedt
2023-01-10 1:03 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1sr9Jp97_NrvPuONjFiULHdnz0AJuBGcigJvHQcYe12o4Q@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).