Re: [PATCH] Fix compiler error in KsSession.cpp on Raspberry Pi 3

[Alan Mikhak <alanmikhak@gmail.com>]

On Wed, Jun 12, 2019 at 5:12 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 12 Jun 2019 07:34:35 +0000
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
> > On 12.06.19 г. 6:59 ч., Alan Mikhak wrote:
> > > Fix compiler error at KsSession.cpp:457:30 on Raspberry Pi 3
> > >
> > > Fix by changing the type of local variable 'pos' from uint64_t to
> > > size_t in KsSession::loadDualMarker().
> > >
> > > KsSession.cpp:457:30: error: no matching function for call to
> > > ‘KsSession::_getMarker(const char [6], uint64_t*)’
> > >    if (_getMarker("markA", &pos)) {
> > >                                ^
> > > In file included from KsSession.cpp:14:0:
> > > KsSession.hpp:97:7: note: candidate:
> > >   bool KsSession::_getMarker(const char*, size_t*)
> > >    bool _getMarker(const char* name, size_t *pos);
> > >         ^~~~~~~~~~
> > > KsSession.hpp:97:7: note:   no known conversion for
> > > argument 2 from ‘uint64_t* {aka long long unsigned int*}’
> > > to ‘size_t* {aka unsigned int*}’
> > >
> > > Signed-off-by: Alan Mikhak <amikhak@wirelessfabric.com>
> > > ---
> > >   kernel-shark/src/KsSession.cpp | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/kernel-shark/src/KsSession.cpp b/kernel-shark/src/KsSession.cpp
> > > index 9d86776..a581bbf 100644
> > > --- a/kernel-shark/src/KsSession.cpp
> > > +++ b/kernel-shark/src/KsSession.cpp
> > > @@ -450,7 +450,7 @@ void KsSession::saveDualMarker(KsDualMarkerSM *dm)
> > >    */
> > >   void KsSession::loadDualMarker(KsDualMarkerSM *dm, KsTraceGraph *graphs)
> > >   {
> > > -   uint64_t pos;
> > > +   size_t pos;
> > >
> > >     dm->reset();
> > >     dm->setState(DualMarkerState::A);
> > >
> >
> >
> > Hi Alan,
> > Thanks a lot for this fix!
> >
> > Reviewed-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> >
>
> Thanks Alan and Yordan.
>
> I queued this patch for my next push to the repo (currently working on
> some other things before I do that push).
>
> -- Steve

Hi Steve and Yordan,

FYI, I ran the kernel get_maintainers.pl script when preparing this
patch but the script didn't suggest linux-trace-devel@vger.kernel.org
or either of you as maintainers.

Regards,
Alan