From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695EAC432C0 for ; Thu, 28 Nov 2019 14:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41DD221771 for ; Thu, 28 Nov 2019 14:58:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RMxcnElL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbfK1O6T (ORCPT ); Thu, 28 Nov 2019 09:58:19 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:46990 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727070AbfK1O6S (ORCPT ); Thu, 28 Nov 2019 09:58:18 -0500 Received: by mail-pj1-f65.google.com with SMTP id z21so422689pjq.13 for ; Thu, 28 Nov 2019 06:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ofzzLMeUvLtpO6voxM8jG8HHKlrbg871nMkONEinivo=; b=RMxcnElLYA9zWNWRtPXzncKBI101kAKV9bfcbUjZ6e/bmzwxcVfgl4063kug9E6RZh reg28x2YkdB/DgF99rncbXSrkAsodBoyYGgfpbPN9wg/B3opqAgHLY7arU0IEthngPbp t7CAmMWSo8Gw7q9My9EgFXy2/j34hk+pjUgdnBPLWU8/d+jFJHBjhGabWc8TNkh9diM1 ExWPjhwA45SfCHL7yhj7q8ZEd4GhQlxW7jb+uzRS1/yu6QVEIq4uBuYvDM5gA4Zwnw9g sa2z5qND7VmT//jnQOUbUBqi9i1D1zFO3qxJbtNkBNOD2d5Vnld2UylYXxZKyJBQ0tWU 6+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ofzzLMeUvLtpO6voxM8jG8HHKlrbg871nMkONEinivo=; b=KbgOrl31Ihnm1z85/tZlh8d6yDcWpzaLIMX6UQAm9omDmDemw7VcOHaxqZSddYX56W pyIejQFq3bih+NXjk7zM3SqAoN5pXBa++bDqU3jrMEhEWYNylJPMjaqFLDNKuuo6hy5g CI2Md6mINM5GGr89jUaCWKHblW45nv3wLKSRGRYwj59q4S/HtWnCTPD6rbSXnP4jAJkw ClrOyzT1b/L5MxqFNv7NemROrYW0GupG7WZ0+70Y9zBNOPTQDoKn8TrxBFCC1QwOMBUD kNcdbDbJojdaVoa9LwkHliIY7Qkx+TmvQAnz/ePvghNKa/zhML+kFES6qHoRKUHl0QjR OZqA== X-Gm-Message-State: APjAAAX5BLV6nLTqZTi/Miw9WrI6ySiRHyESSW/zzqQo8Wu7N69oPnv7 Um9SayFrHrXgkfqlQzlrLReRJ0Ad4E7DeFMzIBU= X-Google-Smtp-Source: APXvYqzjWnmSmIL/LMU0WTgPNvoU7JpnERLpcAO62SmNP8cxlh60E4ywSFeQ0/HFxOSP+rEX1tmw0TE7LBSDF6xklWw= X-Received: by 2002:a17:90a:2947:: with SMTP id x7mr12954132pjf.136.1574953098032; Thu, 28 Nov 2019 06:58:18 -0800 (PST) MIME-Version: 1.0 References: <20191128085409.289684-1-tz.stoyanov@gmail.com> <20191128085409.289684-12-tz.stoyanov@gmail.com> In-Reply-To: From: Tzvetomir Stoyanov Date: Thu, 28 Nov 2019 16:58:06 +0200 Message-ID: Subject: Re: [PATCH v15 11/18] trace-cmd: Exchange tracing IDs between host and guest To: Slavomir Kaslev Cc: Steven Rostedt , linux-trace-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, Nov 28, 2019 at 4:34 PM Slavomir Kaslev wrote: > ... > > - ret = tracecmd_msg_recv_trace_req(msg_handle, &argc, &argv, &use_fifos); > > + ret = tracecmd_msg_recv_trace_req(msg_handle, &argc, &argv, > > + &use_fifos, &trace_id); > > Why is `tracecmd_msg_recv_trace_req` receiving trace_id if it's > getting generated by the agent below? > Each peer generates its own trace id and stores it in its trace.dat file. tracecmd_msg_recv_trace_req() receives the trace ID of the host and tracecmd_msg_send_trace_resp() replies its own trace ID. May be it is a good idea in case of guest to not generate trace ID, but to use the one generated by the host ? > > if (ret < 0) > > die("Failed to receive trace request"); > > > > @@ -153,13 +155,13 @@ static void agent_handle(int sd, int nr_cpus, int page_size) > > > > if (!use_fifos) > > make_vsocks(nr_cpus, fds, ports); > > - > > + trace_id = tracecmd_generate_traceid(); > > ret = tracecmd_msg_send_trace_resp(msg_handle, nr_cpus, page_size, > > - ports, use_fifos); > > + ports, use_fifos, trace_id); > > if (ret < 0) > > die("Failed to send trace response"); > > - > > - trace_record_agent(msg_handle, nr_cpus, fds, argc, argv, use_fifos); > > + trace_record_agent(msg_handle, nr_cpus, fds, argc, argv, > > + use_fifos, trace_id); > > > > free(argv[0]); > > free(argv); > > Cheers, > > -- Slavi -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center