From: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtracefs: Implement tracefs_warning()
Date: Wed, 7 Apr 2021 19:59:39 +0300 [thread overview]
Message-ID: <CAPpZLN5YeKp0tFLLTwqz4wyH7UXFoptm_bViuyPK6oimiFTOkw@mail.gmail.com> (raw)
In-Reply-To: <20210407125554.17b480e5@gandalf.local.home>
On Wed, Apr 7, 2021 at 7:55 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 7 Apr 2021 12:54:32 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > 3. A weak function specific to each library is a more straightforward
> > > way and the user has the flexibility to control warnings per library.
> > > The overhead to add library specific wrappers to those weak functions
> > > is not so big.
> >
> > It's an unnecessary burden. You may add libtracecmd, and want to capture
> > all the warnings and overwrite tracecmd_warning(), but then see that
> > there's other warnings coming from libtraceevent and libtracefs that you
> > never included (because libtracecmd pulled them in). And it's not obvious
> > how to deal with them.
>
> I'm fine if you want to make them all weak, but I really like to have a
> single function that can control all of them.
I'll submit the next version with weak functions for each library and
all of them using the __weak tep_vwarning() for the printing.
>
> -- Steve
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
next prev parent reply other threads:[~2021-04-07 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 5:11 [PATCH] libtracefs: Implement tracefs_warning() Tzvetomir Stoyanov (VMware)
2021-04-07 16:19 ` Steven Rostedt
2021-04-07 16:46 ` Tzvetomir Stoyanov
2021-04-07 16:54 ` Steven Rostedt
2021-04-07 16:55 ` Steven Rostedt
2021-04-07 16:59 ` Tzvetomir Stoyanov [this message]
2021-04-07 17:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpZLN5YeKp0tFLLTwqz4wyH7UXFoptm_bViuyPK6oimiFTOkw@mail.gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).