From: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] trace-cmd: Some more minor updates
Date: Tue, 14 Apr 2020 17:16:04 +0300 [thread overview]
Message-ID: <CAPpZLN5b2MsLpF0ajkHgQzg=dBDi_tkW7zhFgwkVRwyQcJds_w@mail.gmail.com> (raw)
In-Reply-To: <20200414014403.968063641@goodmis.org>
On Tue, Apr 14, 2020 at 4:44 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> These are minor changes and instead of having Tzvetomir resend the patches
> with the updates, I just made the changes.
>
> First patch is to change the grammar of the function names that have
> "file_exist" and "dir_exist" to "file_exists" and "dir_exists" respectively,
> as they sound better for a native English speaker.
>
> The second is just a micro-optimization of the return code of
> check_file_exists().
>
> Steven Rostedt (VMware) (2):
> trace-cmd: Use "exists" instead of "exist"
> trace-cmd: Optimize check_file_exists()
>
Looks good, thanks Steven!
Reviewed-by: Tzvetomir (VMware) Stoyanov <tz.stoyanov@gmail.com>
> ----
> include/tracefs/tracefs.h | 4 ++--
> lib/tracefs/tracefs-instance.c | 21 ++++++++-------------
> tracecmd/trace-record.c | 2 +-
> utest/tracefs-utest.c | 28 ++++++++++++++--------------
> 4 files changed, 25 insertions(+), 30 deletions(-)
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
prev parent reply other threads:[~2020-04-14 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 1:44 [PATCH 0/2] trace-cmd: Some more minor updates Steven Rostedt
2020-04-14 1:44 ` [PATCH 1/2] trace-cmd: Use "exists" instead of "exist" Steven Rostedt
2020-04-14 1:44 ` [PATCH 2/2] trace-cmd: Optimize check_file_exists() Steven Rostedt
2020-04-14 14:16 ` Tzvetomir Stoyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpZLN5b2MsLpF0ajkHgQzg=dBDi_tkW7zhFgwkVRwyQcJds_w@mail.gmail.com' \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).