Re: [PATCH] kernel-shark-2.alpha: Use new tracecmd API to open guest tracing file

[Tzvetomir Stoyanov <tz.stoyanov@gmail.com>]

On Mon, Apr 6, 2020 at 4:24 PM Yordan Karadzhov (VMware)
<y.karadz@gmail.com> wrote:
>
>
>
> On 3.04.20 г. 20:12 ч., Tzvetomir Stoyanov wrote:
> >> Maybe it has to be a bit more sophisticated. Does the "primary" stream
> >> know how to recognize its "secondary" streams?
> >>
> > Yes, there are tracing IDs in both host and guest files. When these IDs match,
> > files are from a same tracing session.
> > I can add "parent_stream_id" member in "struct kshark_data_stream" and
> > initialize it
> > when reading the files, according to the trace IDs.
>
> Not sure if this is the right place to put this information. I do not
> want to have "tep data" specific fields in "struct kshark_data_stream".
> Is it possible to have this mapping stored in in "struct tepdata_handle"
> instead.
Actually, the only new thing in "struct kshark_data_stream" will be the id of
the parent stream, "int parent_stream_id". All tracecmd specific mappings are in
"struct tracecmd_input" and will be accessible via tracecmd APIs.
Currently I assume that the stream with ID 0 is parent to all other
streams, opened with "-a" option.
This assumption will be removed when this "parent_stream_id" is introduced.

>
> Thanks!
> Yordan



-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center