From: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: libtraceevent sync
Date: Thu, 18 Jun 2020 18:55:29 +0300 [thread overview]
Message-ID: <CAPpZLN6Xd0fiBUxKUCn=-z5JsHRocWAUPBtmTFJ=Z6Nj6qbfPA@mail.gmail.com> (raw)
In-Reply-To: <20200618114657.34351921@oasis.local.home>
On Thu, Jun 18, 2020 at 6:47 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 18 Jun 2020 14:43:42 +0300
> Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
>
> > kernel/traceevent/plugins commits, should be added in
> > trace-cmd/traceevent/plugins:
> > "libtraceevent: Remove unneeded semicolon"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eebe80c982546ce1041b7dcf3c461406f1e7e88f
> > "tools lib traceevent: Fix memory leakage in filter_event"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f84ae29a6169318f9c929720c49d96323d2bbab9
> > "tools lib traceevent: Take care of return value of asprintf"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f8ff18be1f5c6ba1c2befb043bea6e7eaf9f8987
>
> The above are fine.
>
> > "tools lib traceevent: Added support for pkg-config"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc03e1a8f82dff36fb329469c28cbfe7d2e6156a
>
> Hmm, do we need this? If the plan is to make traceevent its own
> package, I don't think we need to have pkg-config for trace-cmd.
>
> > "tools lib traceevent: Remove hard coded install paths from
> > pkg-config file"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=53dbabfe50262eeebb56ce18789c3c885f15e6ac
>
> Same for this one. I don't think the libraries should be installed via trace-cmd.
There is already an "install_libs" target in trace-cmd top Makefile. I
think all libraries which are supposed to be used with 3th party
applications should be integrated with pkg-config infrastructure.
>
>
> >
> > kernel/traceevent/plugins commits, should be added in
> > trace-cmd/traceevent/plugins:
> > "tools lib traceevent: update KVM plugin"
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2f465deef7ce8c722121b782dd91c284f5ae80ca
>
> This is good.
>
> Thanks Tzvetomir!
>
> -- Steve
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
next prev parent reply other threads:[~2020-06-18 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 11:43 libtraceevent sync Tzvetomir Stoyanov
2020-06-18 13:58 ` Steven Rostedt
2020-06-18 16:03 ` Tzvetomir Stoyanov
2020-06-18 19:27 ` Steven Rostedt
2020-06-18 15:46 ` Steven Rostedt
2020-06-18 15:55 ` Tzvetomir Stoyanov [this message]
2020-06-18 17:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpZLN6Xd0fiBUxKUCn=-z5JsHRocWAUPBtmTFJ=Z6Nj6qbfPA@mail.gmail.com' \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).