From: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2] libtracefs: Add new API for open trace marker file
Date: Thu, 8 Apr 2021 16:21:52 +0300 [thread overview]
Message-ID: <CAPpZLN7-H536pJxU1ovn6L_wGzmFOzXtVngdWrcSwH+LQvRVdw@mail.gmail.com> (raw)
In-Reply-To: <20210408085935.77e2fd4e@gandalf.local.home>
On Thu, Apr 8, 2021 at 3:59 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 8 Apr 2021 11:08:21 +0300
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
>
> > Added new APIs for opening trace_marker file of given instance:
> > tracefs_marker_init()
> > tracefs_marker_write()
> > tracefs_marker_vprint()
> > tracefs_marker_print()
> > tracefs_marker_close()
>
> I really don't like the name as it's more about the tracefs implementation
> and not what it's used for. I much rather have:
>
> tracefs_print_init();
> tracefs_printf();
> tracefs_vprintf();
> tracefs_print_close();
>
> And you should never write binary into the trace_marker file, as it always
> expects ascii strings. That's the trace_marker_raw file. In which case we
> could have:
>
> tracefs_binary_init();
> tracefs_binary_write();
> tracefs_binary_close();
>
> For binary writes.
>
I find "tracefs_print_" a little bit confusing, like printing
something on console. I think the name should stress that a user
string/data is written in the trace buffer. I would like to combine
string and binary APIs into one set, something like:
tracefs_user_trace_init(); /* open both trace_marker and
trace_marker_raw files, or have flags to specify what file to open,
string or data*/
tracefs_user_trace_printf(); /* write to trace_marker */
tracefs_user_trace_vprintf(); /* write to trace_marker */
tracefs_user_trace_binary(); /* write to trace_marker_raw */
tracefs_user_trace_init(); /* close both string and data fd, if open */
> -- Steve
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
next prev parent reply other threads:[~2021-04-08 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:08 [PATCH v2] libtracefs: Add new API for open trace marker file Tzvetomir Stoyanov (VMware)
2021-04-08 12:59 ` Steven Rostedt
2021-04-08 13:21 ` Tzvetomir Stoyanov [this message]
2021-04-08 13:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpZLN7-H536pJxU1ovn6L_wGzmFOzXtVngdWrcSwH+LQvRVdw@mail.gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).