Re: [PATCH 15/24] kernel-shark: Update KsDualMarker and KsGLWidget

[Tzvetomir Stoyanov <tz.stoyanov@gmail.com>]

On Mon, Feb 1, 2021 at 7:26 PM Yordan Karadzhov (VMware)
<y.karadz@gmail.com> wrote:
>
> The compilation of KsDualMarker.cpp and KsGLWidget.cpp is re-enabled
> and all functionalities are made compatible with the new version of
> the C API of libkshark (KernelShark 2.0). The two source files are
> updated in a single patch because of their interdependence.
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
>  src/CMakeLists.txt   |   8 +-
>  src/KsDualMarker.cpp |  23 +-
>  src/KsDualMarker.hpp |  16 +-
>  src/KsGLWidget.cpp   | 718 +++++++++++++++++++++++++++++--------------
>  src/KsGLWidget.hpp   | 187 ++++++++---
>  5 files changed, 651 insertions(+), 301 deletions(-)
>

[...]

>  /** Reimplemented function used to set up all required OpenGL resources. */
>  void KsGLWidget::initializeGL()
>  {
> +       const char *family = KS_FONT, *name = "aaa";//KS_FONT;

The name of the font should not be hardcoded.

> +       char *font_file = ksplot_find_font_file(family, name);
> +       if (!font_file) {
> +               QErrorMessage *em = new QErrorMessage(this);
> +               QString text("Unable to find ");
> +               text += KS_FONT;
> +               text += " font.";
> +
> +               qCritical().noquote() << "ERROR:" << text;
> +               em->showMessage(text);
> +
> +               return;
> +       }
> +

[...]


--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center