From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00AF1C4338F for ; Wed, 4 Aug 2021 12:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2C4D60EFF for ; Wed, 4 Aug 2021 12:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237330AbhHDM2G (ORCPT ); Wed, 4 Aug 2021 08:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236758AbhHDM2G (ORCPT ); Wed, 4 Aug 2021 08:28:06 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CDDCC0613D5; Wed, 4 Aug 2021 05:27:53 -0700 (PDT) Date: Wed, 4 Aug 2021 14:27:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628080071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wge5H3ohVu9KXZ7XjLIwa/xxD3n3Ba0yHl81R3u0frA=; b=MOh7k18uhCf+MgMnNnUIHRYL5O8XUW5VqzJ8lNWxFnJN11YbJBaMGSiiJwiCA7o2e30sLR tMR69cRX1CZL312mDITZuGx/j8EoB14c8PMB1CO23kblozN06AcR0ZcrX070tuTy5ud9Yf mBpAhZBtCLZPK/PVHMNm+gmaevz9hSkwZJzDZATZBx0mv03/6Xr9RkKxgFG7fjXY+c6Pf0 HdY0YO2EXNi7hsUUCgGDtCgp+vLzWJBjNub6RZMcL2oWDYfBJsWLlhBoNGGywF2apsxaA1 RU3kqSRbChkznr23W6u8imITLNQRX8DLD7oNo4lamfiwfZPz9IgfywWMW+Dr2w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628080071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wge5H3ohVu9KXZ7XjLIwa/xxD3n3Ba0yHl81R3u0frA=; b=HLf7HfrLeP6rzmVeqro9DbhiKXsH2RvNuNcn93Kb8lcfxBtaEasCaOEARSTvn1rz4bR8UB EI1HBnpOqGOg7oDQ== From: "Ahmed S. Darwish" To: Steven Rostedt Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Zanussi , Daniel Bristot de Oliveira , Masami Hiramatsu , Namhyung Kim , linux-rt-users , Clark Williams Subject: Re: [PATCH 17/17] libtracefs: Add man page for tracefs_sql() Message-ID: References: <20210730221824.595597-1-rostedt@goodmis.org> <20210730221824.595597-18-rostedt@goodmis.org> <20210801182916.689a84a8@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210801182916.689a84a8@rorschach.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Sun, Aug 01, 2021, Steven Rostedt wrote: > On Sun, 1 Aug 2021 15:39:25 +0200 > "Ahmed S. Darwish" wrote: > > > On Fri, Jul 30, 2021, Steven Rostedt wrote: > > > + > > > +The SQL format is as follows: > > > + > > > +*SELECT* FROM JOIN ON WHERE > > > + > > > +Note, although the examples show the SQL commands in uppercase, they are not required to > > > +be so. That is, you can use "SELECT" or "select" or "sElEct". > > > + > > > > Maybe it would be helpful to mention that, unlike normal SELECT queries, > > the JOIN and ON parts above are _not_ optional? > > > > That is, generic "one event source" queries: > > > > SELECT common_pid,msr,val FROM write_msr WHERE msr=72 > > > > are not supported. (I wish they were though ;-)) > > Actually, the sql parser should support it, but it will fail on the > creation of events. That's because I started trying to make this create > normal histograms. The problem is, that it can't really do a 1 to 1 on > histograms and selects, so I gave up. But perhaps for the subset it can > create, maybe I can still have it do so. That may require changing the > API slightly. > > I'm not a big SQL person, so I don't know all the magic and I have no > idea how to add the "values" part of the hist trigger. > Thanks! I've replied at the v2 thread. (Discovered after-the-fact that a v3 was already sent, sorry..) -- Ahmed S. Darwish Linutronix GmbH