Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] kernel-shark-qt: Cosmetic modifications in KsQuickContextMenu
Date: Wed, 9 Jan 2019 16:38:09 +0000
Message-ID: <a784cecc-a473-75d3-8b62-6a56edbc5440@vmware.com> (raw)
In-Reply-To: <20190109113317.751b3561@gandalf.local.home>



On 9.01.19 г. 18:33 ч., Steven Rostedt wrote:
> On Wed,  9 Jan 2019 15:09:41 +0200
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> 
>> The following minor modifications in KsQuickContextMenu are introduced:
>>
>> 1. Removes the "Apply to list/graph" check-boxes.
>> 2. Swaps the position of the Show / Hide actions
>> 3. Adds "clear all filters" action.
>>
> This should actually be three separate patches. Even if they are minor,
> each patch should only do one thing, with the exception of formatting
> clean ups. Formatting clean ups can be done when the code that's being
> cleaned up is being changed.
> 
> But the above are three distinct changes, and should be three distinct
> patches. I know it's a little tedious to do it this way, but it's the
> cleaner approach.
> 
> Can you resend with them separate?
> 

Yes, I can do this.
Is there anything else that has to change in this series?

Thanks!
Yordan

> -- Steve
> 
> 
>> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
>> ---
>>   kernel-shark-qt/src/KsQuickContextMenu.cpp | 63 +++++++---------------
>>   kernel-shark-qt/src/KsQuickContextMenu.hpp |  4 +-
>>   2 files changed, 23 insertions(+), 44 deletions(-)
>>
>>

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 13:09 [PATCH v2 0/6] Modifications toward KS 1.0 Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 1/6] kernel-shark-qt: Rearrange the "Filter" top menu Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 2/6] kernel-shark-qt: Cosmetic modifications in KsQuickContextMenu Yordan Karadzhov
2019-01-09 16:33   ` Steven Rostedt
2019-01-09 16:38     ` Yordan Karadzhov [this message]
2019-01-09 16:47       ` Steven Rostedt
2019-01-09 13:09 ` [PATCH v2 3/6] kernel-shark-qt: Make the selection in the Table less touchy Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 4/6] kernel-shark-qt: Do not auto-scrolling when the marker switches Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 5/6] kernel-shark-qt: Add the CPU filters to the filter clearing method Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 6/6] kernel-shark-qt: Fix bug in plugin actions execution Yordan Karadzhov
2019-01-09 16:52   ` Steven Rostedt
2019-03-15  0:01     ` Steven Rostedt
2019-03-15  0:05       ` Steven Rostedt
2019-03-15  6:20         ` Yordan Karadzhov

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a784cecc-a473-75d3-8b62-6a56edbc5440@vmware.com \
    --to=ykaradzhov@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox