From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>,
linux-trace-devel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
Date: Tue, 10 Sep 2019 11:42:06 -0700 [thread overview]
Message-ID: <c458e734f5777561138b87228384808398547762.camel@perches.com> (raw)
In-Reply-To: <20190910142621.0bec208d@oasis.local.home>
On Tue, 2019-09-10 at 14:26 -0400, Steven Rostedt wrote:
> On Tue, 10 Sep 2019 10:18:44 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > > It's not just for the lastest kernel. We must maintain backward
> > > compatibility here too. If there use to be a usage of this, then we
> > > must keep it until the kernels are no longer used (perhaps 7 years?)
> >
> > That argues for not using "%pfw" at all for some number of years.
> >
> > Perhaps the '%pfw' should be '%pnfw' for 'name' and 'fwnode'
>
> -ENOCOMPREHENSION
Perhaps you were not copied on the whole series.
https://lore.kernel.org/lkml/20190910084707.18380-1-sakari.ailus@linux.intel.com/
As I understand it, Sakair Ailus is proposing to
obsolete the current vsprintf "%p[Ff]" extension
and replace the usage with a new "%pfw" extension
which would emit the name of a pointer to "struct fwnode {}".
https://lore.kernel.org/lkml/20190910084707.18380-10-sakari.ailus@linux.intel.com/
If reusing "%pf<foo>" is a problem, then instead
it might be reasonable to have a new "%pn<foo>" for
that use instead.
btw:
Is there kernel version information available in
trace output files?
If so, it might be reasonable to change the tooling
there instead.
next prev parent reply other threads:[~2019-09-10 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190910084707.18380-1-sakari.ailus@linux.intel.com>
2019-09-10 8:46 ` [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Sakari Ailus
2019-09-10 9:22 ` Andy Shevchenko
2019-09-10 11:18 ` Steven Rostedt
2019-09-10 17:18 ` Joe Perches
2019-09-10 18:26 ` Steven Rostedt
2019-09-10 18:42 ` Joe Perches [this message]
2019-09-10 19:03 ` Steven Rostedt
2019-09-10 19:44 ` Joe Perches
2019-09-16 11:41 ` Sakari Ailus
2019-09-16 14:37 ` Steven Rostedt
2019-09-18 13:08 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c458e734f5777561138b87228384808398547762.camel@perches.com \
--to=joe@perches.com \
--cc=acme@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).