[PATCH] trace-cmd: Add dependencies to BUILDING section in README

[PATCH] trace-cmd: Add dependencies to BUILDING section in README

[victorcora98]

From: Victor Cora Colombo <victorcora98@gmail.com>

KernelShark has instructions in its README on how to get necessary
dependencies to build it. trace-cmd could follow this example and
also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries
and dependencies to build trace-cmd.

Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
---
 README | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/README b/README
index 1153152..16aedac 100644
--- a/README
+++ b/README
@@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
 BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config bison flex -y
+
+To install required dependencies:
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
 To make trace-cmd
     make
 
-- 
2.32.0

Re: [PATCH] trace-cmd: Add dependencies to BUILDING section in README

[Steven Rostedt]

On Thu, 12 Aug 2021 19:33:53 -0300
victorcora98@gmail.com wrote:

> From: Victor Cora Colombo <victorcora98@gmail.com>
> 
> KernelShark has instructions in its README on how to get necessary
> dependencies to build it. trace-cmd could follow this example and
> also add more information on how to build it.
> 
> This patch adds instructions to README on how to get necessary libraries
> and dependencies to build trace-cmd.

Thanks for sending this.

> 
> Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
> ---
>  README | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/README b/README
> index 1153152..16aedac 100644
> --- a/README
> +++ b/README
> @@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
>  
>  BUILDING:
>  
> +In order to install build dependencies on Ubuntu do the following:
> +    sudo apt-get install build-essential git pkg-config bison flex -y

Note, once the libtracefs settles down, I plan on committing the files
that are generated by bison and flex, so it shouldn't be a requirement
once libtracefs 1.3 is officially released. That is, because the files
generated by flex and bison will be included in the repository, you do
not need to include bison or flex to build it. Unless you plan on
modifying the bison and flex source files.

Also, can we have a Fedora version? If you don't know what that is, I
could come up with the equivalents.

-- Steve


> +
> +To install required dependencies:
> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
> +    cd libtraceevent
> +    make
> +    sudo make install
> +
> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
> +    cd libtracefs
> +    make
> +    sudo make install
> +
>  To make trace-cmd
>      make
>  

Re: [PATCH] trace-cmd: Add dependencies to BUILDING section in README

[Victor Cora Colombo]

On 8/12/21 11:23 PM, Steven Rostedt wrote:
> On Thu, 12 Aug 2021 19:33:53 -0300
> victorcora98@gmail.com wrote:
> 
>> From: Victor Cora Colombo <victorcora98@gmail.com>
>>
>> KernelShark has instructions in its README on how to get necessary
>> dependencies to build it. trace-cmd could follow this example and
>> also add more information on how to build it.
>>
>> This patch adds instructions to README on how to get necessary libraries
>> and dependencies to build trace-cmd.
> 
> Thanks for sending this.
> 
>>
>> Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
>> ---
>>   README | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/README b/README
>> index 1153152..16aedac 100644
>> --- a/README
>> +++ b/README
>> @@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
>>   
>>   BUILDING:
>>   
>> +In order to install build dependencies on Ubuntu do the following:
>> +    sudo apt-get install build-essential git pkg-config bison flex -y
> 
> Note, once the libtracefs settles down, I plan on committing the files
> that are generated by bison and flex, so it shouldn't be a requirement
> once libtracefs 1.3 is officially released. That is, because the files
> generated by flex and bison will be included in the repository, you do
> not need to include bison or flex to build it. Unless you plan on
> modifying the bison and flex source files.
> 
> Also, can we have a Fedora version? If you don't know what that is, I
> could come up with the equivalents.
> 
> -- Steve
> 

Hello Steve, thanks for your kind reply.

I will come up with a Fedora version and send the updated patch tomorrow.
Also, given what you said, I think it is better then to remove bison and 
flex from this patch, and I will also do this when I send the updated patch.

Best regards,

-- Victor

> 
>> +
>> +To install required dependencies:
>> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
>> +    cd libtraceevent
>> +    make
>> +    sudo make install
>> +
>> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
>> +    cd libtracefs
>> +    make
>> +    sudo make install
>> +
>>   To make trace-cmd
>>       make
>>   
>