From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] kernel-shark: Revert adding environment variables to kshark-su-record
Date: Fri, 26 Jul 2019 10:51:18 +0300 [thread overview]
Message-ID: <e0e0974d-a2b7-8c0c-96fd-ac918ad32a2f@gmail.com> (raw)
In-Reply-To: <20190725194738.979632340@goodmis.org>
On 25.07.19 г. 22:45 ч., Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> This reverts:
>
> 8eb0d753e ("kernel-shark: Execute kshark-record from same dir as kshark-su-record")
> b084eb5aa ("kernel-shark: Set the DISPLAY environment for pkexec kshark-record")
>
> As the policykit (when installed correctly), should handle both the path to
> the executable, as well as the DISPLAY and XAUTHORITY environment variables.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark/bin/kshark-su-record | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record
> index c14f03da9684..70d781d84335 100755
> --- a/kernel-shark/bin/kshark-su-record
> +++ b/kernel-shark/bin/kshark-su-record
> @@ -2,5 +2,4 @@
>
> xhost +si:localuser:root &>/dev/null
>
> -THIS_DIR=`dirname $0`
> -pkexec env DISPLAY=${DISPLAY} ${THIS_DIR}/kshark-record -o ${PWD}/trace.dat
> +pkexec kshark-record -o ${PWD}/trace.dat
>
next prev parent reply other threads:[~2019-07-26 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 19:45 [PATCH 0/2] kernel-shark: Let polkit decide the environment and path of kshark-record Steven Rostedt
2019-07-25 19:45 ` [PATCH 1/2] kernel-shark: Revert adding environment variables to kshark-su-record Steven Rostedt
2019-07-26 7:51 ` Yordan Karadzhov (VMware) [this message]
2019-07-25 19:45 ` [PATCH 2/2] kernel-shark: Revert adding relative path to policy installation Steven Rostedt
2019-07-26 7:51 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e0974d-a2b7-8c0c-96fd-ac918ad32a2f@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).