linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" 
	<linux-trace-devel@vger.kernel.org>,
	"troyengel@gmail.com" <troyengel@gmail.com>
Subject: Re: [PATCH v2 3/3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package"
Date: Mon, 8 Jul 2019 12:16:24 +0300	[thread overview]
Message-ID: <e3d051df-ff9c-ab70-eae9-66f97dafa005@gmail.com> (raw)
In-Reply-To: <20190705193431.7594c3f2@gandalf.local.home>



On 6.07.19 г. 2:34 ч., Steven Rostedt wrote:
> On Fri, 14 Jun 2019 13:26:59 +0000
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> 
>> A special build type dedicated for package maintainers is added.
>> By default this build type adds the "-O2" compiler flag. Users
>> can chose their own compiler flags by providing the corresponding
>> CMAKE_XXXX_FLAGS_PACKAGE Command-Line options.
>>
>> If no type is specified, the build type will be "Debug".
>>
>> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> 
> Hmm, after applying this commit, I get this:
> 
>   <trace-cmd.git># make install_gui
>   <trace-cmd.git># cd
>   <~/># kernelshark
> kernelshark: error while loading shared libraries: libkshark-gui.so.0.9.8: cannot open shared object file: No such file or directory
> 

Thanks!
I see my mistake. Is turns that we need to set CMAKE_INSTALL_RPATH 
regardless of the choice to build with or without RPATH. This is not 
made clear in the CMake documentation. So the line

set(CMAKE_INSTALL_RPATH "${_INSTALL_PREFIX}/lib/${KS_APP_NAME}/")

has to go outside of the IF. I will send new version of the patch.

Yordan


> -- Steve
> 

      reply	other threads:[~2019-07-08  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 13:26 [PATCH v2 0/3] KernelShark build fixes for v1.0 Yordan Karadzhov
2019-06-14 13:26 ` [PATCH v2 1/3] kernel-shark: Remove the "-g" compiler flag Yordan Karadzhov
2019-06-14 13:26 ` [PATCH v2 2/3] kernel-shark: Avoid TRACECMD_BIN_DIR being set to the build path Yordan Karadzhov
2019-06-14 13:26 ` [PATCH v2 3/3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package" Yordan Karadzhov
2019-07-05 23:34   ` Steven Rostedt
2019-07-08  9:16     ` Yordan Karadzhov (VMware) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3d051df-ff9c-ab70-eae9-66f97dafa005@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=troyengel@gmail.com \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).