From: Yordan Karadzhov <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] kernel-shark: Change the mechanism of the multi-threaded search
Date: Sat, 2 May 2020 21:47:28 +0300 [thread overview]
Message-ID: <f0947778-bfb5-4f0f-15a5-636e81f2a92d@Gmail.com> (raw)
In-Reply-To: <20200430225637.1b05d3ed@gandalf.local.home>
On 1.05.20 г. 5:56 ч., Steven Rostedt wrote:
> On Mon, 27 Apr 2020 15:18:02 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>>> I would say we can apply both. What do you think?
>> I'll try it out and let you know.
> Want to resend this patch with this change?
OK, Thanks!
Yordan
>
> -- Steve
>
> diff --git a/kernel-shark/src/KsModels.cpp b/kernel-shark/src/KsModels.cpp
> index ac58ca0a..51a7b79f 100644
> --- a/kernel-shark/src/KsModels.cpp
> +++ b/kernel-shark/src/KsModels.cpp
> @@ -91,7 +91,7 @@ size_t KsFilterProxyModel::_search(int column,
> }
>
> /* Deal with the Progress bar of the seatch. */
> - if ((index - first) > milestone) {
> + if ((index - first) >= milestone) {
> milestone += pbCount;
> if (notify) {
> /*
> diff --git a/kernel-shark/src/KsTraceViewer.cpp b/kernel-shark/src/KsTraceViewer.cpp
> index 12371ad7..0e0e3d4e 100644
> --- a/kernel-shark/src/KsTraceViewer.cpp
> +++ b/kernel-shark/src/KsTraceViewer.cpp
> @@ -788,7 +788,7 @@ void KsTraceViewer::_searchItemsMT()
> false)); // notify = false
>
> while (_searchFSM.getState() == search_state_t::InProgress_s &&
> - _proxyModel.searchProgress() < KS_PROGRESS_BAR_MAX - nThreads) {
> + _proxyModel.searchProgress() < KS_PROGRESS_BAR_MAX - nThreads - 1) {
> std::unique_lock<std::mutex> lk(_proxyModel._mutex);
> _proxyModel._pbCond.wait(lk);
> _searchFSM.setProgress(_proxyModel.searchProgress());
next prev parent reply other threads:[~2020-05-02 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:17 [PATCH 0/3] Have "stop" button for multi-threaded searches Yordan Karadzhov (VMware)
2020-03-30 16:17 ` [PATCH 1/3] kernel-shark: Simplify the search methods in class KsTraceViewer Yordan Karadzhov (VMware)
2020-03-30 16:17 ` [PATCH 2/3] kernel-shark: Change the mechanism of the multi-threaded search Yordan Karadzhov (VMware)
2020-04-24 20:12 ` Steven Rostedt
2020-04-27 14:44 ` Yordan Karadzhov (VMware)
2020-04-27 19:18 ` Steven Rostedt
2020-05-01 2:56 ` Steven Rostedt
2020-05-02 1:03 ` Steven Rostedt
2020-05-02 18:48 ` Yordan Karadzhov
2020-05-02 18:47 ` Yordan Karadzhov [this message]
2020-03-30 16:17 ` [PATCH 3/3] kernel-shark: Make the "stop search" button always visible Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0947778-bfb5-4f0f-15a5-636e81f2a92d@Gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).