From: Jiri Olsa <jolsa@redhat.com> To: ahmadkhorrami <ahmadkhorrami@ut.ac.ir> Cc: Steven Rostedt <rostedt@goodmis.org>, Arnaldo Carvalho de Melo <acme@redhat.com>, Linux-trace Users <linux-trace-users@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, linux-trace-users-owner@vger.kernel.org, Jin Yao <yao.jin@linux.intel.com>, Milian Wolff <milian.wolff@kdab.com>, Namhyung Kim <namhyung@kernel.org>, Andi Kleen <ak@linux.intel.com> Subject: Re: Wrong Perf Backtraces Date: Sun, 29 Mar 2020 13:19:59 +0200 Message-ID: <20200329111959.GC2155755@krava> (raw) In-Reply-To: <8a58f8eda97525e5e49daeb001107c9d@ut.ac.ir> On Sun, Mar 29, 2020 at 05:46:57AM +0430, ahmadkhorrami wrote: > Hi, > Each line is correct. I mean addresses match symbols. But some callers and > callees do not match. Perhaps callchain misses some callers in between. > Regards right, I missed another case.. how about the change below? your script is silent now on my data jirka --- diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index 3b4842840db0..fc4fb88937ed 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -173,6 +173,8 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (print_srcline) printed += map__fprintf_srcline(map, addr, "\n ", fp); + else if (node->srcline) + printed += fprintf(fp, " %s", node->srcline); if (sym && sym->inlined) printed += fprintf(fp, " (inlined)");
next prev parent reply index Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <157597d74ff17f781d9de7e7e3defd13@ut.ac.ir> 2020-03-22 20:24 ` ahmadkhorrami 2020-03-23 0:34 ` Steven Rostedt [not found] ` <21b3df4080709f193d62b159887e2a83@ut.ac.ir> 2020-03-23 8:49 ` Jiri Olsa 2020-03-23 10:03 ` ahmadkhorrami 2020-03-25 15:18 ` ahmadkhorrami 2020-03-25 15:46 ` Jiri Olsa 2020-03-25 18:54 ` ahmadkhorrami 2020-03-25 18:58 ` Arnaldo Carvalho de Melo 2020-03-25 19:10 ` ahmadkhorrami 2020-03-25 19:28 ` Arnaldo Carvalho de Melo 2020-03-25 20:01 ` ahmadkhorrami 2020-03-25 20:39 ` Jiri Olsa 2020-03-25 21:02 ` Jiri Olsa 2020-03-25 21:09 ` Steven Rostedt 2020-03-25 21:37 ` ahmadkhorrami 2020-03-25 21:46 ` Jiri Olsa 2020-03-25 22:21 ` ahmadkhorrami 2020-03-25 23:09 ` ahmadkhorrami 2020-03-26 9:59 ` Jiri Olsa 2020-03-26 13:20 ` ahmadkhorrami 2020-03-26 15:39 ` Jiri Olsa 2020-03-26 18:19 ` ahmadkhorrami 2020-03-26 18:21 ` ahmadkhorrami 2020-03-27 9:20 ` Jiri Olsa 2020-03-27 10:59 ` ahmadkhorrami 2020-03-27 11:04 ` ahmadkhorrami 2020-03-27 12:10 ` Milian Wolff 2020-03-27 12:58 ` ahmadkhorrami 2020-03-27 13:25 ` Milian Wolff 2020-03-27 13:33 ` ahmadkhorrami 2020-03-27 18:43 ` ahmadkhorrami 2020-03-27 22:37 ` Jiri Olsa 2020-03-27 23:12 ` ahmadkhorrami 2020-03-28 23:34 ` Jiri Olsa 2020-03-29 0:43 ` ahmadkhorrami 2020-03-29 1:16 ` ahmadkhorrami 2020-03-29 11:19 ` Jiri Olsa [this message] 2020-03-29 11:52 ` ahmadkhorrami 2020-03-29 12:08 ` Jiri Olsa 2020-03-29 12:39 ` ahmadkhorrami 2020-03-29 13:50 ` Milian Wolff 2020-03-29 14:23 ` ahmadkhorrami 2020-03-29 19:20 ` Jiri Olsa 2020-03-30 6:09 ` Milian Wolff 2020-03-30 13:07 ` Jiri Olsa 2020-03-30 13:49 ` ahmadkhorrami 2020-03-30 19:05 ` ahmadkhorrami 2020-03-30 21:05 ` debuginfod-based dwarf downloading, was " Frank Ch. Eigler 2020-03-31 9:26 ` Jiri Olsa 2020-03-31 14:00 ` Frank Ch. Eigler 2020-03-31 4:43 ` ahmadkhorrami 2020-03-31 9:30 ` Jiri Olsa 2020-03-31 11:53 ` ahmadkhorrami 2020-03-31 12:43 ` ahmadkhorrami 2020-03-31 13:20 ` Jiri Olsa 2020-03-31 13:39 ` ahmadkhorrami 2020-03-31 14:44 ` Milian Wolff 2020-03-31 15:02 ` ahmadkhorrami 2020-03-31 15:05 ` ahmadkhorrami 2020-03-31 15:29 ` Milian Wolff 2020-03-31 16:10 ` Arnaldo Carvalho de Melo 2020-03-31 19:20 ` ahmadkhorrami 2020-03-31 19:17 ` ahmadkhorrami 2020-03-31 20:57 ` ahmadkhorrami 2020-04-04 1:01 ` ahmadkhorrami 2020-04-11 16:42 ` ahmadkhorrami 2020-04-11 21:04 ` ahmadkhorrami
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200329111959.GC2155755@krava \ --to=jolsa@redhat.com \ --cc=acme@redhat.com \ --cc=ahmadkhorrami@ut.ac.ir \ --cc=ak@linux.intel.com \ --cc=linux-trace-users-owner@vger.kernel.org \ --cc=linux-trace-users@vger.kernel.org \ --cc=milian.wolff@kdab.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=yao.jin@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Trace-Users Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-trace-users/0 linux-trace-users/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-trace-users linux-trace-users/ https://lore.kernel.org/linux-trace-users \ linux-trace-users@vger.kernel.org public-inbox-index linux-trace-users Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-users AGPL code for this site: git clone https://public-inbox.org/public-inbox.git