From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E91C43331 for ; Sun, 29 Mar 2020 11:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E1CA20774 for ; Sun, 29 Mar 2020 11:20:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B/VuDlr7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgC2LUM (ORCPT ); Sun, 29 Mar 2020 07:20:12 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:27601 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727916AbgC2LUM (ORCPT ); Sun, 29 Mar 2020 07:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585480811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4BjtDjkiHAfcCZYW0SXGNS3UcXktsM9u5dp6BXSh0WU=; b=B/VuDlr7tW+NH6VsCglxL9AQP7zGMO3bntirT4stjYdckwklodqpNCM5YaOjTBY9myJXv0 znpj+UsQlWbg+XwX68Rfp7Vh830NMtjQwLttFVARveeS4ZSUPRYO936aY1SW+3qFuOydWQ FVE/CGsWU7g3/VMf5avvEgKA+lIsm3E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-wzbvNXfONuSQlxLSP0Q7rQ-1; Sun, 29 Mar 2020 07:20:06 -0400 X-MC-Unique: wzbvNXfONuSQlxLSP0Q7rQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1EE97107ACCA; Sun, 29 Mar 2020 11:20:05 +0000 (UTC) Received: from krava (unknown [10.40.192.75]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 13FF75DA76; Sun, 29 Mar 2020 11:20:01 +0000 (UTC) Date: Sun, 29 Mar 2020 13:19:59 +0200 From: Jiri Olsa To: ahmadkhorrami Cc: Steven Rostedt , Arnaldo Carvalho de Melo , Linux-trace Users , Peter Zijlstra , linux-trace-users-owner@vger.kernel.org, Jin Yao , Milian Wolff , Namhyung Kim , Andi Kleen Subject: Re: Wrong Perf Backtraces Message-ID: <20200329111959.GC2155755@krava> References: <20200327092045.GH1947699@krava> <821540886fc57d7749edee585a50602f@ut.ac.ir> <20200327223743.GA2155755@krava> <57b9e24200019a41bd465e2d78c09e29@ut.ac.ir> <20200328233431.GB2155755@krava> <8a58f8eda97525e5e49daeb001107c9d@ut.ac.ir> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a58f8eda97525e5e49daeb001107c9d@ut.ac.ir> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-trace-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-users@vger.kernel.org On Sun, Mar 29, 2020 at 05:46:57AM +0430, ahmadkhorrami wrote: > Hi, > Each line is correct. I mean addresses match symbols. But some callers and > callees do not match. Perhaps callchain misses some callers in between. > Regards right, I missed another case.. how about the change below? your script is silent now on my data jirka --- diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index 3b4842840db0..fc4fb88937ed 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -173,6 +173,8 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (print_srcline) printed += map__fprintf_srcline(map, addr, "\n ", fp); + else if (node->srcline) + printed += fprintf(fp, " %s", node->srcline); if (sym && sym->inlined) printed += fprintf(fp, " (inlined)");