Linux-Trace-Users Archive on lore.kernel.org
 help / color / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Andi Kleen <andi@firstfloor.org>,
	Jin Yao <yao.jin@linux.intel.com>
Cc: ahmadkhorrami <ahmadkhorrami@ut.ac.ir>,
	Linux-trace Users <linux-trace-users@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: Perf Reports Jump Instructions as Memory Access Instructions
Date: Tue, 26 May 2020 10:38:17 -0300
Message-ID: <20200526133817.GA23187@redhat.com> (raw)

Em Mon, May 25, 2020 at 10:52:25AM -0400, Steven Rostedt escreveu:
> Arnaldo,
>
> This one may be for you ;-)

Humm, I think linux-perf-users@vger.kernel.org may be better, I'm also
adding some Intel guys that work on perf that may be of help.

Jin came to mind as having worked in this feature in the past:

commit 7e63a13a266da652f82731b845b5c35dd866ec7e
Author: Jin Yao <yao.jin@linux.intel.com>
Date:   Fri Jul 7 13:06:35 2017 +0800

    perf annotate: Implement visual marker for macro fusion

    For marking fused instructions clearly this patch adds a line before
the
    first instruction of pair and joins it with the arrow of the jump to
its
    target.

    For example, when "je" is selected in annotate view, the line before
    cmpl is displayed and joins the arrow of "je".

           │   ┌──cmpl   $0x0,argp_program_version_hook
     81.93 │   ├──je     20
           │   │  lock   cmpxchg %esi,0x38a9a4(%rip)
           │   │↓ jne    29
           │   │↓ jmp    43
     11.47 │20:└─→cmpxch %esi,0x38a999(%rip)

I took a stab at explaining it, but I'm not sure that makes sense, take
a look :)
 
> On Sun, 17 May 2020 19:40:52 +0430 ahmadkhorrami <ahmadkhorrami@ut.ac.ir> wrote:
> > I used the following perf command to sample user space read accesses to 
> > DRAM by evince:
> > perf record -d --call-graph dwarf -c 100 -e 
> > mem_load_uops_retired.l3_miss:uppp /opt/evince-3.28.4/bin/evince

> > As can be seen, I used the PEBS feature to increase the accuracy of 
> > sampling. But there are some non-memory accesses reported as memory 
> > ones. Here is one of them reported by perf script -D:
> > 11159097179866 0xfb80 [0x1778]: PERF_RECORD_SAMPLE(IP, 0x4002): 
> > 7309/7309: 0x7ffff6d6c310 period: 10000 addr: 0x7ffff7034e50
> > ... FP chain: nr:0
> > ... user regs: mask 0xff0fff ABI 64-bit
> > .... AX    0x555555b8b4c0
> > .... BX    0x555555c48e10
> > .... CX    0x1
> > .... DX    0x7fffffffd988
> > .... SI    0x7fffffffd980
> > .... DI    0x555555b8b4c0
> > .... BP    0x258
> > .... SP    0x7fffffffd978
> > .... IP    0x7ffff6d6c310
> > .... FLAGS 0x20e
> > .... CS    0x33
> > .... SS    0x2b
> > .... R8    0x27c
> > .... R9    0x24
> > .... R10   0x2a2
> > .... R11   0x0
> > .... R12   0x258
> > .... R13   0x555555b8b4c0
> > .... R14   0x3000
> > .... R15   0x7ffff5747000
> > ... ustack: size 5768, offset 0xd8
> >   . data_src: 0x5080022
> >   ... thread: evince:7309
> >   ...... dso: /usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30
> > evince  7309 11159.097179:      10000    
> > mem_load_uops_retired.l3_miss:uppp:     7ffff7034e50         5080022 
> > N/A|SNP N/A|TLB N/A|LCK N/A
> >          7ffff6d6c310 cairo_surface_get_device_scale@plt+0x0 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d91029 gdk_window_create_similar_surface+0xc9 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d95410 gdk_window_begin_paint_internal+0x350 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d956f1 gdk_window_begin_draw_frame+0xc1 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff73c4942 gtk_widget_render+0xd2 
> > (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30)
> >          7ffff7268858 gtk_main_do_event+0x708 
> > (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30)
> >          7ffff6d79764 _gdk_event_emit+0x24 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d897f4 _gdk_window_process_updates_recurse_helper+0x104 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d8a9f5 gdk_window_process_updates_internal+0x165 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d8abef gdk_window_process_updates_with_mode+0x11f 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff574510c g_closure_invoke+0x19c 
> > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
> >          7ffff575805d signal_emit_unlocked_R+0xf4d 
> > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
> >          7ffff5760714 g_signal_emit_valist+0xa74 
> > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
> >          7ffff576112e g_signal_emit+0x8e 
> > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
> >          7ffff6d82ac8 gdk_frame_clock_paint_idle+0x3c8 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff6d6e07f gdk_threads_dispatch+0x1f 
> > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30)
> >          7ffff546ad02 g_timeout_dispatch+0x12 
> > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4)
> >          7ffff546a284 g_main_dispatch+0x154 (inlined)
> >          7ffff546a284 g_main_context_dispatch+0x154 
> > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4)
> >          7ffff546a64f g_main_context_iterate+0x1ff (inlined)
> >          7ffff546a6db g_main_context_iteration+0x2b 
> > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4)
> >          7ffff5a2be3c g_application_run+0x1fc 
> > (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.5600.4)
> >          555555573707 main+0x447 (/opt/evince-3.28.4/bin/evince)
> >          7ffff4a91b96 __libc_start_main+0xe6 
> > (/lib/x86_64-linux-gnu/libc-2.27.so)
> >          555555573899 _start+0x29 (/opt/evince-3.28.4/bin/evince)
> > 
> > The access point is at offset 0 of the following disassembly:
 > Dump of assembler code for function cairo_surface_get_device_scale@plt:
> >     0x000000000002a310 <+0>:     jmpq   *0x2c8b3a(%rip)        # 0x2f2e50
> >     0x000000000002a316 <+6>:     pushq  $0x1c7
> >     0x000000000002a31b <+11>:    jmpq   0x28690
> > 
> > This is an unconditional jump which will not lead to macrofusion.

But that will access memory, no? The instruction at offset 0.

 11159097179866 0xfb80 [0x1778]: PERF_RECORD_SAMPLE(IP, 0x4002): 7309/7309: 0x7ffff6d6c310 period: 10000 addr: 0x7ffff7034e50

 .... IP    0x7ffff6d6c310

So the sample was at 0x7ffff6d6c310 and was for the addr 0x7ffff7034e50:

  jmpq   *0x2c8b3a(%rip)

IP + 0x2c8b3a == 0x7ffff6d6c310 + 0x2c8b3a == 0x7ffff7034e4a

0x7ffff7034e4a - 0x7ffff7034e50 == -0x6

Close enough? Some PEBS measurement skid? Jin?

> > Any help is appreciated.

- Arnaldo


             reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 13:38 Arnaldo Carvalho de Melo [this message]
2020-05-26 16:42 ` Andi Kleen
2020-05-26 19:55   ` ahmadkhorrami
2020-06-03  3:49     ` ahmadkhorrami
  -- strict thread matches above, loose matches on Subject: below --
2020-05-17 15:10 ahmadkhorrami
2020-05-23 18:07 ` ahmadkhorrami
2020-05-25 14:52 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526133817.GA23187@redhat.com \
    --to=acme@redhat.com \
    --cc=acme@kernel.org \
    --cc=ahmadkhorrami@ut.ac.ir \
    --cc=andi@firstfloor.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Users Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-users/0 linux-trace-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-users linux-trace-users/ https://lore.kernel.org/linux-trace-users \
		linux-trace-users@vger.kernel.org
	public-inbox-index linux-trace-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git