From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80B15C433EF for ; Thu, 7 Jul 2022 14:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234818AbiGGO04 (ORCPT ); Thu, 7 Jul 2022 10:26:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232153AbiGGO0z (ORCPT ); Thu, 7 Jul 2022 10:26:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DF8F28E13 for ; Thu, 7 Jul 2022 07:26:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DD266224B for ; Thu, 7 Jul 2022 14:26:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1924FC3411E; Thu, 7 Jul 2022 14:26:52 +0000 (UTC) Date: Thu, 7 Jul 2022 10:26:51 -0400 From: Steven Rostedt To: Daniel Wagner Cc: linux-trace-users@vger.kernel.org Subject: Re: [RFC v1 1/2] libtracefs: Use explicit libtraceevent include path Message-ID: <20220707102651.43dc2042@gandalf.local.home> In-Reply-To: <20220707140723.hhkkjuckchqwnvnl@carbon> References: <20220707121542.28434-1-dwagner@suse.de> <20220707094752.6ec14f7a@gandalf.local.home> <20220707140723.hhkkjuckchqwnvnl@carbon> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-users@vger.kernel.org On Thu, 7 Jul 2022 16:07:23 +0200 Daniel Wagner wrote: > On Thu, Jul 07, 2022 at 09:47:52AM -0400, Steven Rostedt wrote: > > On Thu, 7 Jul 2022 14:15:41 +0200 > > Daniel Wagner wrote: > > > > > The libtraceevent pkg-config generated by meson is not adding the > > > subdirectory to the CLFAGS. This is generally a good idea in order to > > > avoid any file name collisions. Hence use explicit include paths for > > > libtraceevent. > > > > Is there a way to fix this. Honestly, I hate the libtraceevent name (should > > at least be traceevent), and I have been thinking of changing it. > > I suppose we can change pkg-config so that the complete path is > included, with the downside that file name collisions are more likely to > happen. E.g. the kbuffer.h is very a generic name. Sorta-of ;-) That's actually the file I want to "claim" first! > > In libnvme/nvme-cli we had some troubles consuming libuuid because of > inconsistent use of include paths. As far I can tell we just need to > state what the correct includes paths are. > > > If we do not have pkg-config working and everything needs to add explicit > > include paths, then I'll never be able to change it, or even just get rid > > of the subdirectory. > > I am not really expert how to structure the include paths. As said, I > think the most important bit is that we use it consistent. Let me try to > add the include path to pkg-config. Thanks, -- Steve