linux-trace-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-users@vger.kernel.org
Subject: Re: [RFC v1] libtraceevent: Add initial support for meson
Date: Thu, 7 Jul 2022 16:01:13 +0200	[thread overview]
Message-ID: <20220707140113.ephz6il665xc4nh4@carbon> (raw)
In-Reply-To: <20220707094422.1bf96c9d@gandalf.local.home>

On Thu, Jul 07, 2022 at 09:44:22AM -0400, Steven Rostedt wrote:
> Thanks for doing this. Hopefully I'll get some time to try it out.

Cool, let me know if you need any help. There are some (low) hurdles to
jump over but nothing serious IMO.

> Anyway, as for the libtraceevent-dynamic-list, it was brought over from the
> kernel tools/lib directory. I guess it is needed for the plugins to work
> properly, although I have not had issues with it.

The current Makefile doesn't install it nor use it in anyway. Chances
are no one is using it. Also looking at the content shows a handful of
symbols which shouldn't be there:

{
        free;
        memcpy;
        memset;
        realloc;
        sprintf;
        strcmp;
        strdup;
        strncmp;
        tep_find_any_field;
        tep_find_field;
        tep_find_function;
...
};

> But if you want to know more, see commit e3d09ec8126fe ("tools lib
> traceevent: Export dynamic symbols used by traceevent plugins") in the
> Linux kernel source.

Well, if this is a use case which needs to be supported we might need to
figure out how to get a correct export map. In a different project we
currently maintain the map file manual with the usual problems of
syncing up the *.c files and the map file. I was thinking about
introducing a macro like the ones in the kernel *_EXPORT from which the
map file is generated. Just as idea.

      reply	other threads:[~2022-07-07 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 12:14 [RFC v1] libtraceevent: Add initial support for meson Daniel Wagner
2022-07-07 13:44 ` Steven Rostedt
2022-07-07 14:01   ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707140113.ephz6il665xc4nh4@carbon \
    --to=dwagner@suse.de \
    --cc=linux-trace-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).