linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Srinivasarao Pathipati <quic_c_spathi@quicinc.com>
Cc: anton ivanov <anton.ivanov@cambridgegreys.com>,
	 Johannes Berg <johannes@sipsolutions.net>,
	 linux-um <linux-um@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1] um: Fix compilation warnings
Date: Tue, 14 Feb 2023 22:57:01 +0100 (CET)	[thread overview]
Message-ID: <1950127775.130646.1676411821807.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1676410243-10566-1-git-send-email-quic_c_spathi@quicinc.com>

----- Ursprüngliche Mail -----
> Von: "Srinivasarao Pathipati" <quic_c_spathi@quicinc.com>
> static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc)
> {
> -	struct uml_pt_regs r;
> +	struct uml_pt_regs *r;
> 	int save_errno = errno;
> 
> -	r.is_user = 0;
> +	r = malloc(sizeof(struct uml_pt_regs));

I fear this is not correct since malloc() is not async-signal safe.

Thanks,
//richard

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

  reply	other threads:[~2023-02-14 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 21:30 [PATCH V1] um: Fix compilation warnings Srinivasarao Pathipati
2023-02-14 21:57 ` Richard Weinberger [this message]
2023-02-15  5:35   ` Srinivasarao Pathipati
2023-02-15  8:07     ` Geert Uytterhoeven
2023-02-15  8:13       ` Johannes Berg
2023-02-15  8:14       ` Srinivasarao Pathipati
2023-02-15  8:14   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1950127775.130646.1676411821807.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=quic_c_spathi@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).