From: Jan Kiszka <jan.kiszka@siemens.com>
To: Glenn Washburn <development@efficientek.com>,
Kieran Bingham <kbingham@kernel.org>
Cc: linux-um <linux-um@lists.infradead.org>,
Richard Weinberger <richard@nod.at>,
Johannes Berg <johannes@sipsolutions.net>,
Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Subject: Re: [PATCH 1/2] scripts/gdb: Correct indentation in get_current_task
Date: Wed, 15 Feb 2023 08:44:06 +0100 [thread overview]
Message-ID: <76578d08-0faa-59b5-9a51-444446125c4a@siemens.com> (raw)
In-Reply-To: <f33ebe524590314238b48fe620c9af717b1db096.1676416728.git.development@efficientek.com>
On 15.02.23 00:35, Glenn Washburn wrote:
> There is an extra space in a couple blocks in get_current_task.
> Though python does not care, let's make the spacing consistent.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
> scripts/gdb/linux/cpus.py | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py
> index 15fc4626d236..289f0bf4d2a1 100644
> --- a/scripts/gdb/linux/cpus.py
> +++ b/scripts/gdb/linux/cpus.py
> @@ -163,16 +163,16 @@ def get_current_task(cpu):
> task_ptr_type = task_type.get_type().pointer()
>
> if utils.is_target_arch("x86"):
> - var_ptr = gdb.parse_and_eval("¤t_task")
> - return per_cpu(var_ptr, cpu).dereference()
> + var_ptr = gdb.parse_and_eval("¤t_task")
> + return per_cpu(var_ptr, cpu).dereference()
> elif utils.is_target_arch("aarch64"):
> - current_task_addr = gdb.parse_and_eval("$SP_EL0")
> - if((current_task_addr >> 63) != 0):
> - current_task = current_task_addr.cast(task_ptr_type)
> - return current_task.dereference()
> - else:
> - raise gdb.GdbError("Sorry, obtaining the current task is not allowed "
> - "while running in userspace(EL0)")
> + current_task_addr = gdb.parse_and_eval("$SP_EL0")
> + if((current_task_addr >> 63) != 0):
At this chance: "if (current_task_addr >> 63) != 0:"
> + current_task = current_task_addr.cast(task_ptr_type)
> + return current_task.dereference()
> + else:
> + raise gdb.GdbError("Sorry, obtaining the current task is not allowed "
> + "while running in userspace(EL0)")
> else:
> raise gdb.GdbError("Sorry, obtaining the current task is not yet "
> "supported with this arch")
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-02-15 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 23:35 [PATCH 0/2] GDB: Support getting current task struct in UML Glenn Washburn
2023-02-14 23:35 ` [PATCH 1/2] scripts/gdb: Correct indentation in get_current_task Glenn Washburn
2023-02-15 7:44 ` Jan Kiszka [this message]
2023-02-14 23:35 ` [PATCH 2/2] scripts/gdb: Support getting current task struct in UML Glenn Washburn
2023-02-15 7:45 ` Jan Kiszka
2023-02-15 15:55 ` Glenn Washburn
2023-02-15 16:04 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76578d08-0faa-59b5-9a51-444446125c4a@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=anton.ivanov@kot-begemot.co.uk \
--cc=development@efficientek.com \
--cc=johannes@sipsolutions.net \
--cc=kbingham@kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).