linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	 Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	linux-ide@vger.kernel.org,  linux-um@lists.infradead.org
Subject: Re: [PATCH] ata: pata_cs5536: don't build on UML
Date: Sun, 12 Mar 2023 12:38:52 +0100	[thread overview]
Message-ID: <CAMuHMdXia3d8dV1EyNcmgA=k_osEAkHZkA4ya9xjzyEVO4YjGQ@mail.gmail.com> (raw)
In-Reply-To: <20230312052624.8402-1-rdunlap@infradead.org>

Hi Randy,

On Sun, Mar 12, 2023 at 6:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Similar to 22eebaa631c4 ("ata: pata_cs5535: Don't build on UML"),
> prevent pata_cs5536 from building on UML since it references
> symbols that are not present when building X86_32/i386 allmodconfig.
>
> ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks for your patch!

> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -650,6 +650,7 @@ config PATA_CS5535
>  config PATA_CS5536
>         tristate "CS5536 PATA support"
>         depends on PCI && (X86_32 || MIPS || COMPILE_TEST)

How does this work on MIPS?
Oh, the MSR functionality inside the driver depends on CONFIG_X86_32.
Perhaps this can be fixed better for all users inside
arch/x86/include/asm/msr.h?

> +       depends on !UML
>         help
>           This option enables support for the AMD CS5536
>           companion chip used with the Geode LX processor family.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

      reply	other threads:[~2023-03-12 11:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-12  5:26 [PATCH] ata: pata_cs5536: don't build on UML Randy Dunlap
2023-03-12 11:38 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXia3d8dV1EyNcmgA=k_osEAkHZkA4ya9xjzyEVO4YjGQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).