archive mirror
 help / color / mirror / Atom feed
* [PATCH] IMA: allow/fix UML builds
@ 2023-02-24  3:27 Randy Dunlap
  2023-03-13  0:15 ` Randy Dunlap
  2023-03-14 18:28 ` Mimi Zohar
  0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-02-24  3:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Mimi Zohar, Dmitry Kasatkin, linux-integrity,
	Fabio Estevam, Rajiv Andrade, Richard Weinberger, Anton Ivanov,
	Johannes Berg, linux-um

UML supports HAS_IOMEM since 0bbadafdc49d (um: allow disabling

Current IMA build on UML fails on allmodconfig (with TCG_TPM=m):

ld: security/integrity/ima/ima_queue.o: in function `ima_add_template_entry':
ima_queue.c:(.text+0x2d9): undefined reference to `tpm_pcr_extend'
ld: security/integrity/ima/ima_init.o: in function `ima_init':
ima_init.c:(.init.text+0x43f): undefined reference to `tpm_default_chip'
ld: security/integrity/ima/ima_crypto.o: in function `ima_calc_boot_aggregate_tfm':
ima_crypto.c:(.text+0x1044): undefined reference to `tpm_pcr_read'
ld: ima_crypto.c:(.text+0x10d8): undefined reference to `tpm_pcr_read'

Modify the IMA Kconfig entry so that it selects TCG_TPM if HAS_IOMEM
is set, regardless of the UML Kconfig setting.
This updates TCG_TPM from =m to =y and fixes the linker errors.

Fixes: f4a0391dfa91 ("ima: fix Kconfig dependencies")
Signed-off-by: Randy Dunlap <>
Cc: Mimi Zohar <>
Cc: Dmitry Kasatkin <>
Cc: Fabio Estevam <>
Cc: Rajiv Andrade <>
Cc: Richard Weinberger <>
Cc: Anton Ivanov <>
Cc: Johannes Berg <>
 security/integrity/ima/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -8,7 +8,7 @@ config IMA
 	select CRYPTO_HMAC
 	select CRYPTO_SHA1
-	select TCG_TPM if HAS_IOMEM && !UML
+	select TCG_TPM if HAS_IOMEM
 	select TCG_TIS if TCG_TPM && X86
 	select TCG_CRB if TCG_TPM && ACPI

linux-um mailing list

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-14 21:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24  3:27 [PATCH] IMA: allow/fix UML builds Randy Dunlap
2023-03-13  0:15 ` Randy Dunlap
2023-03-14 18:28 ` Mimi Zohar
2023-03-14 21:23   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).