From: Mike Kravetz <mike.kravetz@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <willy@infradead.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org, Colin Walters <walters@verbum.org>,
syzbot <syzbot+d6ec23007e951dadf3de@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()
Date: Wed, 10 Jun 2020 19:31:57 -0700 [thread overview]
Message-ID: <1bfea970-00f5-502c-3ced-4ebe7fd3eef1@oracle.com> (raw)
In-Reply-To: <20200611021710.GA23230@ZenIV.linux.org.uk>
On 6/10/20 7:17 PM, Al Viro wrote:
> On Wed, Jun 10, 2020 at 06:36:16PM -0700, Matthew Wilcox wrote:
>
>> while (file->f_mode & FMODE_OVL_UPPER)
>> file = file->private_data;
>> return file;
>>
>> Or are you proposing that overlayfs copy FMODE_HUGEPAGES from the
>> underlying fs to the overlaying fs?
>
> The latter - that way nobody outside of overlayfs needs to know what
> its ->private_data points to, for one thing. And it's cheaper that
> way, obviously.
>
Thanks Al and Matthew!
I knew adding a file op for this was overkill and was looking for other
suggestions.
--
Mike Kravetz
prev parent reply other threads:[~2020-06-11 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000000000000b4684e05a2968ca6@google.com>
[not found] ` <aa7812b8-60ae-8578-40db-e71ad766b4d3@oracle.com>
[not found] ` <CAJfpegtVca6H1JPW00OF-7sCwpomMCo=A2qr5K=9uGKEGjEp3w@mail.gmail.com>
[not found] ` <bb232cfa-5965-42d0-88cf-46d13f7ebda3@www.fastmail.com>
[not found] ` <9a56a79a-88ed-9ff4-115e-ec169cba5c0b@oracle.com>
[not found] ` <CAJfpegsNVB12MQ-Jgbb-f=+i3g0Xy52miT3TmUAYL951HVQS_w@mail.gmail.com>
[not found] ` <78313ae9-8596-9cbe-f648-3152660be9b3@oracle.com>
2020-05-22 10:05 ` kernel BUG at mm/hugetlb.c:LINE! Miklos Szeredi
2020-05-28 0:01 ` Mike Kravetz
2020-05-28 8:37 ` [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area() kbuild test robot
2020-05-28 21:01 ` Mike Kravetz
2020-06-04 9:16 ` Miklos Szeredi
2020-06-11 0:13 ` Mike Kravetz
2020-06-11 0:37 ` Al Viro
2020-06-11 1:36 ` Matthew Wilcox
2020-06-11 2:17 ` Al Viro
2020-06-11 2:31 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bfea970-00f5-502c-3ced-4ebe7fd3eef1@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=miklos@szeredi.hu \
--cc=syzbot+d6ec23007e951dadf3de@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walters@verbum.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).