($INBOX_DIR/description missing)
 help / color / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [RFC] unionmount metacopy tests
Date: Tue, 9 Jul 2019 10:13:02 -0400
Message-ID: <20190709141302.GA19084@redhat.com> (raw)
In-Reply-To: <CAOQ4uxhi63LPKdmkEJjnTEgy0VaX0qXML2Uz_258_B2iZcqd3w@mail.gmail.com>

On Thu, Jul 04, 2019 at 06:11:25PM +0300, Amir Goldstein wrote:
> Hi Vivek,
> I was working on extending snapshot validation tests and got
> this as a by-product:
> https://github.com/amir73il/unionmount-testsuite/commits/metacopy
> ca566c3 Check that data was not copied up with metacopy=on
> 140d99c Reset dentry copy_up state on upper layer rotate
> 960a5ce Check that files were copied up as expected
> 1bfcc7d Record meta copy_up vs. data copy_up
> c3db453 Fix instantiation of hardlinked dentry
> 2104e51 Simplify initialization of __upper
> 1fc2eec Fix ./run --ov --verify --recycle
> Would you be interested to review these changes,
> so I would merge them to master?

Hi Amir,

Glad to see more tests for metacopy feature. I will have a look at

> Would you or someone else be interested in running those tests
> regularly on pre release kernel?

I generally don't run tests regularly on latest kernel. Whenever I 
am fixing something, I run tests to make sure I have not broken

So I can't say I will run the tests regularly, but once in a while
I should be able to run it.

> If anyone is running unionmount-testsuite on regular basis
> I would be happy to know which configurations are being tested,
> because the test matrix grew considerably since I took over the project -
> both Overlayfs config options and the testsuite config options.

For me, I think I am most interested in configuration used by
container runtimes (docker/podman). Docker seems to turn off
redirects as of now. podman is turning on metacopy (hence redirect)
by default now to see how do things go.

So for me (redirect=on/off and metacopy=on/off) are important
configurations as of now. Havind said that, I think I should talk
to container folks and encourage them to use "index" and "xino"
as well to be more posix like fs.

I think container folks still have not modified their code to
be able to generate an image layer properly if redirect is
enabled. Last time Miklos had some good ideas. I will poke them
again. It will be nice if they can use redirect (instead of
disabling it) and be able to generate image layer efficiently. 


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 15:11 Amir Goldstein
2019-07-09 14:13 ` Vivek Goyal [this message]
2020-07-31 12:35   ` [RFC] Passing extra mount options to unionmount tests Amir Goldstein
2020-07-31 13:12     ` Vivek Goyal
2020-07-31 14:09       ` Amir Goldstein
2020-07-31 18:21         ` Vivek Goyal
2020-07-31 20:02           ` Amir Goldstein
2020-08-13 11:23     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709141302.GA19084@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git