From: Matthew Wilcox <willy@infradead.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-fsdevel@vger.kernel.org, dhowells@redhat.com,
Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org,
Seth Forshee <seth.forshee@canonical.com>
Subject: Re: [PATCH 1/1] fs: rethread notify_change to take a path instead of a dentry
Date: Sun, 1 Dec 2019 03:47:06 -0800 [thread overview]
Message-ID: <20191201114706.GL20752@bombadil.infradead.org> (raw)
In-Reply-To: <1575148868.5563.30.camel@HansenPartnership.com>
On Sat, Nov 30, 2019 at 01:21:08PM -0800, James Bottomley wrote:
> @@ -402,6 +403,10 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
>
> dentry = fhp->fh_dentry;
> inode = d_inode(dentry);
> + path = &(struct path){
> + .mnt = fhp->fh_export->ex_path.mnt,
> + .dentry = dentry,
> + };
Is this really clearer than writing:
path.mnt = fhp->fh_export->ex_path.mnt;
path.dentry = dentry;
(there are a few other occurrences I'd change)
next prev parent reply other threads:[~2019-12-01 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 21:19 [PATCH 0/1] preparatory patch for a uid/gid shifting bind mount James Bottomley
2019-11-30 21:21 ` [PATCH 1/1] fs: rethread notify_change to take a path instead of a dentry James Bottomley
2019-12-01 7:04 ` Amir Goldstein
2019-12-01 16:00 ` James Bottomley
2019-12-03 0:54 ` [PATCH v2] " James Bottomley
2019-12-01 11:47 ` Matthew Wilcox [this message]
2019-12-01 15:55 ` [PATCH 1/1] " James Bottomley
2019-12-03 9:18 ` [fs] 53d4a4300b: WARNING:at_fs/overlayfs/copy_up.c:#ovl_copy_up_inode[overlay] kernel test robot
2019-12-14 11:56 ` [PATCH 0/1] preparatory patch for a uid/gid shifting bind mount Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191201114706.GL20752@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=seth.forshee@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).