From: Christoph Hellwig <hch@infradead.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu,
adilger@dilger.ca, darrick.wong@oracle.com, hch@infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dan Carpenter <dan.carpenter@oracle.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Murphy Zhou <jencce.kernel@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes
Date: Fri, 24 Apr 2020 03:11:53 -0700 [thread overview]
Message-ID: <20200424101153.GC456@infradead.org> (raw)
In-Reply-To: <cover.1587555962.git.riteshh@linux.ibm.com>
I think the right fix is to move fiemap_check_ranges into all the ->fiemap
instances (we only have a few actual implementation minus the wrappers
around iomap/generic). Then add a version if iomap_fiemap that can pass
in maxbytes explicitly for ext4, similar to what we've done with various
other generic helpers.
The idea of validating input against file systems specific paramaters
before we call into the fs is just bound to cause problems.
next prev parent reply other threads:[~2020-04-24 10:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 10:47 [PATCH 0/5] ext4/overlayfs: fiemap related fixes Ritesh Harjani
2020-04-23 10:47 ` [PATCH 1/5] ext4: Fix EXT4_MAX_LOGICAL_BLOCK macro Ritesh Harjani
2020-04-23 11:16 ` Jan Kara
2020-04-23 10:47 ` [PATCH 2/5] ext4: Rename fiemap_check_ranges() to make it ext4 specific Ritesh Harjani
2020-04-23 11:17 ` Jan Kara
2020-04-23 10:47 ` [PATCH 3/5] vfs: EXPORT_SYMBOL for fiemap_check_ranges() Ritesh Harjani
2020-04-23 11:18 ` Jan Kara
2020-04-23 10:47 ` [PATCH 4/5] overlayfs: Check for range bounds before calling i_op->fiemap() Ritesh Harjani
2020-04-23 11:19 ` Jan Kara
2020-04-25 8:54 ` Amir Goldstein
2020-04-23 10:47 ` [PATCH 5/5] ext4: Get rid of ext4_fiemap_check_ranges Ritesh Harjani
2020-04-23 11:20 ` Jan Kara
2020-04-24 10:11 ` Christoph Hellwig [this message]
2020-04-24 23:20 ` [PATCH 0/5] ext4/overlayfs: fiemap related fixes Ritesh Harjani
2020-04-25 9:11 ` Amir Goldstein
2020-04-25 9:43 ` Christoph Hellwig
2020-04-25 10:49 ` Amir Goldstein
2020-04-25 11:14 ` Ritesh Harjani
2020-04-27 6:28 ` Christoph Hellwig
2020-04-27 10:15 ` Amir Goldstein
2020-04-27 10:38 ` Christoph Hellwig
2020-04-25 17:32 ` Andreas Dilger
2020-04-27 6:42 ` Christoph Hellwig
2020-04-25 9:44 ` Ritesh Harjani
2020-05-19 2:43 ` Murphy Zhou
2020-05-21 6:08 ` Ritesh Harjani
2020-05-22 4:56 ` Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424101153.GC456@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=jencce.kernel@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).