Re: [PATCH 2/2] Configure custom layers via environment variables

[Vivek Goyal <vgoyal@redhat.com>]

On Sun, May 24, 2020 at 01:28:44PM +0300, Amir Goldstein wrote:
> > > Hi Amir,
> > >
> > > Do you want to mention a word upper dir also when UNIONMOUNT_BASEDIR. That
> > > is upperdir is also created under UNIONMOUNT_BASEDIR. IOW, all directories
> > > lower, upper and mount point are under UNIONMOUNT_BASEDIR (until and
> > > unless overridden by other environment variables).
> >
> 
> Hi Vivek,
> 
> Please approve this text before I update master.
> Pushed this work to branch 'envvars'

Hi Amir,

This looks good to me. Thank you for providing these environment
variables. Helps me run these tests on top of virtiofs now.

Vivek

> 
> Thanks,
> Amir.
> 
> -----
> The following environment variables are supported:
> 
>      UNIONMOUNT_BASEDIR  - parent dir of all samefs layers (default: /base)
>      UNIONMOUNT_LOWERDIR - lower layer path for non samefs (default: /lower)
>      UNIONMOUNT_MNTPOINT - mount point for executing tests (default: /mnt)
> 
>      When user provides UNIONMOUNT_LOWERDIR:
> 
>      1) Path should be an existing directory whose content will be deleted.
>      2) Path is assumed to be on a different filesystem than base dir, so
>         --samefs setup is not supported.
> 
>      When user provides UNIONMOUNT_BASEDIR:
> 
>      1) Path should be an existing directory whose content will be deleted.
>      2) Upper layer and middle layers will be created under base dir.
>      3) If UNIONMOUNT_MNTPOINT is not provided, the overlay mount point will
>         be created under base dir.
>      4) If UNIONMOUNT_LOWERDIR is not provided, the lower layer dir will be
>         created under base dir.
>      5) If UNIONMOUNT_LOWERDIR is not provided, the test setup defaults to
>         --samefs (i.e. lower and upper layers are on the same base fs).
>         However, if --maxfs=<M> is specified, a tmpfs instance will be mounted
>         on the lower layer dir that was created under base dir.
>