From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: linux-unionfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [ANNOUNCE] unionmount-testsuite: master branch updated to 9c60a9c
Date: Thu, 18 Jun 2020 17:38:31 -0400 [thread overview]
Message-ID: <20200618213831.GF3814@redhat.com> (raw)
In-Reply-To: <20200529164058.4654-1-amir73il@gmail.com>
On Fri, May 29, 2020 at 07:40:58PM +0300, Amir Goldstein wrote:
> Hi All,
>
> The master branch on the unionmount-testsuite tree [1] has been updated.
>
> Changes in this update:
> - Support user configurable underlying filesystem
>
> So far, unionmount-testsuite used hardcoded paths for layers and
> mount point. Using underlying filesystem other than tmpfs was possible,
> but not very easy to setup.
>
> This update brings the ability for user to configure custom paths
> with a custom filesystem for the underlying layers.
> This is intended to be used for integration with xfstests [2].
>
> Here is an excerpt from the README:
> ---
> The following environment variables are supported:
>
> UNIONMOUNT_BASEDIR - parent dir of all samefs layers (default: /base)
Hi Amir,
I am running these tests with.
UNIONMOUNT_BASEDIR="/mnt/foo/"
- ./run --ov runs fine. But when I try to run it again it complains
that.
rm: cannot remove '/mnt/overlayfs//m': Device or resource busy
So I have to first unmount /mnt/overlayfs/m/ and then run tests
again.
I think it will be nice if it can clear the environment by itself.
- I am running one the recent kernel (5.7.0+) and following errors
out.
# ./run --ov --verify
Environment variables:
UNIONMOUNT_BASEDIR=/mnt/overlayfs/
***
*** ./run --ov --samefs --ts=0 open-plain
***
TEST open-plain.py:10: Open O_RDONLY
/mnt/overlayfs/m/a/foo100: not on union mount
Will spend more time to figure out what happened.
- I am planning to use these environment variables and run overlay over
virtiofs tests. Can I do the same thing with xfstests overlay tests.
In README.overlay I see that I need to specify two separate devices.
Can I specify to directories (and not devices) to be used as TEST
and SCRATCH and run overlay test.
Thanks
Vivek
>
> 1) Path should be an existing directory whose content will be deleted.
> 2) Path is assumed to be on a different filesystem than base dir, so
> --samefs setup is not supported.
>
> When user provides UNIONMOUNT_BASEDIR:
>
> 1) Path should be an existing directory whose content will be deleted.
> 2) Upper layer and middle layers will be created under base dir.
> 3) If UNIONMOUNT_MNTPOINT is not provided, the overlay mount point will
> be created under base dir.
> 4) If UNIONMOUNT_LOWERDIR is not provided, the lower layer dir will be
> created under base dir.
> 5) If UNIONMOUNT_LOWERDIR is not provided, the test setup defaults to
> --samefs (i.e. lower and upper layers are on the same base fs).
> However, if --maxfs=<M> is specified, a tmpfs instance will be
> mounted on the lower layer dir that was created under base dir.
> ---
>
> Many thanks to Vivek for review and testing.
>
> Thanks,
> Amir.
>
> [1] https://github.com/amir73il/unionmount-testsuite
> [2] https://github.com/amir73il/xfstests/commits/unionmount
>
> The head of the master branch is commit:
>
> 9c60a9c Configure custom layers via environment variables
>
> New commits:
>
> Amir Goldstein (3):
> Add command run --clean-up to cleanup old test mounts
> Stop using bind mounts for --samefs
> Configure custom layers via environment variables
>
> README | 26 ++++++++++
> mount_union.py | 13 +----
> run | 32 +++++-------
> set_up.py | 127 +++++++++++++++++++++++++----------------------
> settings.py | 85 +++++++++++++++++++++++++------
> unmount_union.py | 15 +++---
> 6 files changed, 187 insertions(+), 111 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-18 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 16:40 [ANNOUNCE] unionmount-testsuite: master branch updated to 9c60a9c Amir Goldstein
2020-06-18 21:38 ` Vivek Goyal [this message]
2020-06-18 22:06 ` Vivek Goyal
2020-06-19 3:29 ` Amir Goldstein
2020-06-19 14:21 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618213831.GF3814@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).