($INBOX_DIR/description missing)
 help / color / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	Giuseppe Scrivano <gscrivan@redhat.com>,
	Daniel J Walsh <dwalsh@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	pmatilai@redhat.com, sandeen@redhat.com
Subject: Re: [PATCH v4] overlayfs: Provide mount options sync=off/fs to skip sync
Date: Tue, 21 Jul 2020 09:51:23 -0400
Message-ID: <20200721135123.GA551452@redhat.com> (raw)
In-Reply-To: <CAJfpegt2k=r6TRok57tKPcLyUhCBOcBAV7bgLSPrQYXsPoPkpQ@mail.gmail.com>

On Tue, Jul 21, 2020 at 03:15:55PM +0200, Miklos Szeredi wrote:
> On Mon, Jul 20, 2020 at 6:16 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> > For building images containers folks need to sync upper layer. Their
> > current plan is to use "syncfs upper/" because it is same as if overlay
> > was mounted with sync=fs. But this syncs whole upper filesystem and
> > not just upper of a particular overlayfs instance
> >
> > So idea was to provide sync=fs from the beginning and ask container
> > folks to use this. So that in future if we can optimize sync=fs to
> > sync selctive inodes, then container runtime will automatically
> > benefit from it without any changes. It also reduces the chances
> > of error on container runtime which fail to sync upper.  Hence idea
> > of sync=fs sounded appleaing to me.
> Not sure I understand the reason for sync=fs?  Should it rather be
> sync=shutdown?
> >
> > Havid said that, I am open to dropping sync=fs for now, if you don't
> > see the value at this point of time.
> At this point it doesn't add any usefulness, so let's just drop it.

Ok, Will drop it.

> > >
> > > Naming: I'm not at all convinced by any name having "sync" in it.  I
> > > think "sync=no" is about the implementation, not the functionality,
> > > and so it's confusing. The functionality is better described by
> > > "volatile" or "temporary".   But I can live with sync=... if voted
> > > down.
> >
> > I am fine with the name "volatile/temporary" for sync=off.
> How about needing "volatile" for all kinds of modes that reduce the
> normal durability/integrity guarantees.  Then additional "sync=foobar"
> option to control the details?

Sounds good. For now I will just implement "volatile" which is equivalent
of sync=off. One can implement "volatile,sync=shutdown" in future if
need be.


      parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 16:12 Vivek Goyal
2020-07-06 17:16 ` Amir Goldstein
2020-07-20 12:57 ` Miklos Szeredi
2020-07-20 16:16   ` Vivek Goyal
2020-07-20 17:47     ` Amir Goldstein
2020-07-21 13:15     ` Miklos Szeredi
2020-07-21 13:44       ` Amir Goldstein
2020-07-21 13:51       ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721135123.GA551452@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=dwalsh@redhat.com \
    --cc=gscrivan@redhat.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=pmatilai@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=swhiteho@redhat.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git