linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Murphy Zhou <jencce.kernel@gmail.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: Murphy Zhou <jencce.kernel@gmail.com>,
	Amir Goldstein <amir73il@gmail.com>,
	fstests <fstests@vger.kernel.org>,
	Chengguang Xu <cgxu519@mykernel.net>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v2] overlay/073: test with nfs_export being off
Date: Fri, 23 Oct 2020 08:31:35 +0800	[thread overview]
Message-ID: <20201023003135.w25522gphidf7gpn@xzhoux.usersys.redhat.com> (raw)
In-Reply-To: <20201020052229.GL80581@e18g06458.et15sqa>

On Tue, Oct 20, 2020 at 01:22:29PM +0800, Eryu Guan wrote:
> On Tue, Oct 20, 2020 at 10:52:59AM +0800, Murphy Zhou wrote:
> > Ping on this one.
> 
> Queued for next update.
> 
> Sorry, I thought I've applied it and pushed, but clearly I didn't.
> Thanks for the reminder!

No warries :)

> 
> Thanks,
> Eryu
> 
> > 
> > On Fri, Sep 11, 2020 at 10:18:13AM +0800, Murphy Zhou wrote:
> > > When nfs_export is enabled, the link count of upper dir
> > > objects are more then the expected number in this testcase.
> > > Because extra index entries are linked to upper inodes.
> > > 
> > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
> > > ---
> > >  tests/overlay/073 | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/overlay/073 b/tests/overlay/073
> > > index 37860c92..c5deccc6 100755
> > > --- a/tests/overlay/073
> > > +++ b/tests/overlay/073
> > > @@ -99,7 +99,9 @@ run_test_case()
> > >  {
> > >  	_scratch_mkfs
> > >  	make_lower_files ${1}
> > > -	_scratch_mount -o "index=on"
> > > +	# There will be extra hard links with nfs_export enabled which
> > > +	# is expected. Turn it off explicitly to avoid the false alarm.
> > > +	_scratch_mount -o "index=on,nfs_export=off"
> > >  	make_whiteout_files
> > >  	check_whiteout_files ${1} ${2}
> > >  	_scratch_unmount
> > > -- 
> > > 2.20.1
> > > 
> > 
> > -- 
> > Murphy

-- 
Murphy

      reply	other threads:[~2020-10-23  0:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  5:51 [PATCH] overlay/073: test with nfs_export being off Murphy Zhou
2020-09-10 13:59 ` Amir Goldstein
2020-09-11  2:18   ` [PATCH v2] " Murphy Zhou
2020-09-11  2:27     ` Amir Goldstein
2020-10-20  2:52     ` Murphy Zhou
2020-10-20  5:22       ` Eryu Guan
2020-10-23  0:31         ` Murphy Zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023003135.w25522gphidf7gpn@xzhoux.usersys.redhat.com \
    --to=jencce.kernel@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=cgxu519@mykernel.net \
    --cc=eguan@linux.alibaba.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).