From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF613C63699 for ; Fri, 13 Nov 2020 06:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C3F5206D9 for ; Fri, 13 Nov 2020 06:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mykernel.net header.i=cgxu519@mykernel.net header.b="ZOx0TDR/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgKMG5c (ORCPT ); Fri, 13 Nov 2020 01:57:32 -0500 Received: from sender2-op-o12.zoho.com.cn ([163.53.93.243]:17119 "EHLO sender2-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbgKMG5b (ORCPT ); Fri, 13 Nov 2020 01:57:31 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1605250626; cv=none; d=zoho.com.cn; s=zohoarc; b=OyKpOjG8bn+MTWZ0vUICiHaDF0O9XWteKgL9UXJw/YBDH3oY1Ju8vPO13xDvawj+BXFQtdCNkCUU/8CngDUFM1XDcq5HOkWT7jHwIBik2JiRm6IRk2k8j8OXUsqhCobEH3q9VJ/3cVwJhQ8W42Inq+iAJIFIixFpSDoZ+AAWric= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1605250626; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=52hU/5xFiMygbpFTzyIy/fGf4awhCIKsb/DSgoBBVHg=; b=Y7WlfsdWbl9w0ntakr94ZvSuEQGRA5DM6l4P0ZBdYK61O24MecNywOEkgBUqL6BUPE6UA5mxx8YKz1aZDE6s2T54F86oB17alkPaHnzM0LociiRmxfQcaxGEfd7GuRN6wOGusgrw1CLiFfEmRAVbaaXrlfjugXQlsj78p0XVj88= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=mykernel.net; spf=pass smtp.mailfrom=cgxu519@mykernel.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605250626; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=From:To:Cc:Message-ID:Subject:Date:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type; bh=52hU/5xFiMygbpFTzyIy/fGf4awhCIKsb/DSgoBBVHg=; b=ZOx0TDR/FfCQDmELQvgGOvxu9UcCodEG090zoMiRVJAn0G9iMDqPnuR67sVhRlHH kaIXrsHfPXtqRm0O2Idmy4W1RfJs/EUxFNwPSWt9MavAe96/dTWUaNBoFGe7S9gtW+R DSiVClSMosY+q4QbvgwlrcsRL1ZXn9d0gP4HeUrE= Received: from localhost.localdomain (116.30.195.173 [116.30.195.173]) by mx.zoho.com.cn with SMTPS id 1605250625286875.6835648067917; Fri, 13 Nov 2020 14:57:05 +0800 (CST) From: Chengguang Xu To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Chengguang Xu Message-ID: <20201113065555.147276-5-cgxu519@mykernel.net> Subject: [RFC PATCH v4 4/9] ovl: mark overlayfs' inode dirty on modification Date: Fri, 13 Nov 2020 14:55:50 +0800 X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201113065555.147276-1-cgxu519@mykernel.net> References: <20201113065555.147276-1-cgxu519@mykernel.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoCNMailClient: External Content-Type: text/plain; charset=utf8 Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org Mark overlayfs' inode dirty on modification so that we can recognize target inodes during syncfs. Signed-off-by: Chengguang Xu --- fs/overlayfs/inode.c | 1 + fs/overlayfs/overlayfs.h | 4 ++++ fs/overlayfs/util.c | 14 ++++++++++++++ 3 files changed, 19 insertions(+) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 8cfa75e86f56..342693657ab0 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -468,6 +468,7 @@ int ovl_update_time(struct inode *inode, struct timespe= c64 *ts, int flags) =09=09if (upperpath.dentry) { =09=09=09touch_atime(&upperpath); =09=09=09inode->i_atime =3D d_inode(upperpath.dentry)->i_atime; +=09=09=09ovl_mark_inode_dirty(inode); =09=09} =09} =09return 0; diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h index f8880aa2ba0e..eaf1d5b05d8e 100644 --- a/fs/overlayfs/overlayfs.h +++ b/fs/overlayfs/overlayfs.h @@ -247,6 +247,7 @@ static inline bool ovl_open_flags_need_copy_up(int flag= s) } =20 /* util.c */ +void ovl_mark_inode_dirty(struct inode *inode); int ovl_want_write(struct dentry *dentry); void ovl_drop_write(struct dentry *dentry); struct dentry *ovl_workdir(struct dentry *dentry); @@ -472,6 +473,9 @@ static inline void ovl_copyattr(struct inode *from, str= uct inode *to) =09to->i_mtime =3D from->i_mtime; =09to->i_ctime =3D from->i_ctime; =09i_size_write(to, i_size_read(from)); + +=09if (ovl_inode_upper(to) && from->i_state & I_DIRTY_ALL) +=09=09ovl_mark_inode_dirty(to); } =20 static inline void ovl_copyflags(struct inode *from, struct inode *to) diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c index 23f475627d07..a6f59df744ae 100644 --- a/fs/overlayfs/util.c +++ b/fs/overlayfs/util.c @@ -950,3 +950,17 @@ char *ovl_get_redirect_xattr(struct ovl_fs *ofs, struc= t dentry *dentry, =09kfree(buf); =09return ERR_PTR(res); } + +/* + * We intentionally add I_DIRTY_SYNC flag regardless dirty flag + * of upper inode so that we have chance to invoke ->write_inode + * to re-dirty overlayfs' inode during writeback process. + */ +void ovl_mark_inode_dirty(struct inode *inode) +{ +=09struct inode *upper =3D ovl_inode_upper(inode); +=09unsigned long iflag =3D I_DIRTY_SYNC; + +=09iflag |=3D upper->i_state & I_DIRTY_ALL; +=09__mark_inode_dirty(inode, iflag); +} --=20 2.26.2