From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29756C4361A for ; Fri, 4 Dec 2020 16:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB3E422AAF for ; Fri, 4 Dec 2020 16:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgLDQkw (ORCPT ); Fri, 4 Dec 2020 11:40:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:52412 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgLDQkw (ORCPT ); Fri, 4 Dec 2020 11:40:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C281EACC1; Fri, 4 Dec 2020 16:40:10 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 406A91E1327; Fri, 4 Dec 2020 17:40:09 +0100 (CET) Date: Fri, 4 Dec 2020 17:40:09 +0100 From: Jan Kara To: Chengguang Xu Cc: miklos , jack , amir73il , linux-unionfs , linux-fsdevel Subject: Re: =?utf-8?B?5Zue5aSNOltSRg==?= =?utf-8?Q?C?= PATCH v4 0/9] implement containerized syncfs for overlayfs Message-ID: <20201204164009.GA1389@quack2.suse.cz> References: <20201113065555.147276-1-cgxu519@mykernel.net> <1762e3a7bce.e28cb82145070.9060345012556073676@mykernel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1762e3a7bce.e28cb82145070.9060345012556073676@mykernel.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org On Fri 04-12-20 22:49:13, Chengguang Xu wrote: > ---- 在 星期五, 2020-11-13 14:55:46 Chengguang Xu 撰写 ---- > > Current syncfs(2) syscall on overlayfs just calls sync_filesystem() > > on upper_sb to synchronize whole dirty inodes in upper filesystem > > regardless of the overlay ownership of the inode. In the use case of > > container, when multiple containers using the same underlying upper > > filesystem, it has some shortcomings as below. > > > > (1) Performance > > Synchronization is probably heavy because it actually syncs unnecessary > > inodes for target overlayfs. > > > > (2) Interference > > Unplanned synchronization will probably impact IO performance of > > unrelated container processes on the other overlayfs. > > > > This series try to implement containerized syncfs for overlayfs so that > > only sync target dirty upper inodes which are belong to specific overlayfs > > instance. By doing this, it is able to reduce cost of synchronization and > > will not seriously impact IO performance of unrelated processes. > > Hi Miklos, > > I think this version has addressed all previous issues and comments from Jack > and Amir. Have you got time to review this patch series? Yes, the patches now look good to me. Feel free to add: Acked-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR