From: Vivek Goyal <vgoyal@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Cc: jlayton@kernel.org, vgoyal@redhat.com, amir73il@gmail.com,
sargun@sargun.me, miklos@szeredi.hu, willy@infradead.org,
jack@suse.cz, neilb@suse.com, viro@zeniv.linux.org.uk
Subject: [RFC PATCH 0/3] vfs, overlayfs: Fix syncfs() to return error
Date: Wed, 16 Dec 2020 18:31:46 -0500 [thread overview]
Message-ID: <20201216233149.39025-1-vgoyal@redhat.com> (raw)
Hi,
This is V2 of patches which tries to fix syncfs() for overlayfs to
return error code when sync_filesystem(upper_sb) returns error or
there are writeback errors on upper_sb.
I posted V1 of patch here.
https://lore.kernel.org/linux-fsdevel/20201216143802.GA10550@redhat.com/
This is just compile tested patch series. Trying to get early feedback
to figure out what direction to move in to fix this issue.
Thanks
Vivek
Vivek Goyal (3):
vfs: add new f_op->syncfs vector
overlayfs: Implement f_op->syncfs() call
overlayfs: Check writeback errors w.r.t upper in ->syncfs()
fs/overlayfs/file.c | 1 +
fs/overlayfs/overlayfs.h | 3 +++
fs/overlayfs/ovl_entry.h | 2 ++
fs/overlayfs/readdir.c | 1 +
fs/overlayfs/super.c | 41 +++++++++++++++++++++++++++++++++++++++-
fs/sync.c | 29 +++++++++++++++++++---------
include/linux/fs.h | 1 +
7 files changed, 68 insertions(+), 10 deletions(-)
--
2.25.4
next reply other threads:[~2020-12-16 23:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 23:31 Vivek Goyal [this message]
2020-12-16 23:31 ` [PATCH 1/3] vfs: add new f_op->syncfs vector Vivek Goyal
2020-12-17 0:49 ` Al Viro
2020-12-17 9:57 ` Jan Kara
2020-12-17 16:15 ` Vivek Goyal
2020-12-17 15:00 ` Vivek Goyal
2020-12-17 19:49 ` Jeff Layton
2020-12-16 23:31 ` [PATCH 2/3] overlayfs: Implement f_op->syncfs() call Vivek Goyal
2020-12-16 23:31 ` [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs() Vivek Goyal
2020-12-17 20:08 ` Jeffrey Layton
2020-12-18 14:44 ` Vivek Goyal
2020-12-18 15:02 ` Jeff Layton
2020-12-18 16:28 ` Vivek Goyal
2020-12-18 16:55 ` Jeffrey Layton
2020-12-18 20:25 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216233149.39025-1-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.com \
--cc=sargun@sargun.me \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).