From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu
Cc: linux-unionfs@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH] ovl: restore vma->vm_file to old file
Date: Tue, 20 Apr 2021 10:07:38 +0800 [thread overview]
Message-ID: <20210420020738.201670-1-cgxu519@mykernel.net> (raw)
In the error case of ->mmap() we should also restore vma->vm_file
to old file in order to keep correct file reference in error path.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 6e454a294046..046a7adb02c5 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -439,6 +439,7 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
if (ret) {
/* Drop reference count from new vm_file value */
fput(realfile);
+ vma->vm_file = file;
} else {
/* Drop reference count from previous vm_file value */
fput(file);
--
2.27.0
next reply other threads:[~2021-04-20 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 2:07 Chengguang Xu [this message]
2021-04-21 9:47 ` [PATCH] ovl: restore vma->vm_file to old file Miklos Szeredi
2021-04-21 11:03 ` Christian König
2021-04-21 11:14 ` Miklos Szeredi
2021-04-21 11:25 ` Christian König
2021-04-21 12:15 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420020738.201670-1-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).