From: Chengguang Xu <cgxu519@mykernel.net> To: miklos@szeredi.hu Cc: linux-unionfs@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net> Subject: [RFC PATCH 1/2] ovl: skip checking lower file's write permisson on truncate Date: Sat, 24 Apr 2021 22:03:15 +0800 [thread overview] Message-ID: <20210424140316.485444-1-cgxu519@mykernel.net> (raw) Lower files may be shared in overlayfs so strictly checking write perssmion on lower file will cause interferes between different overlayfs instances. Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> --- fs/overlayfs/inode.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 28c71978eb2e..17d1add0af1a 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -31,12 +31,6 @@ int ovl_setattr(struct user_namespace *mnt_userns, struct dentry *dentry, goto out; if (attr->ia_valid & ATTR_SIZE) { - struct inode *realinode = d_inode(ovl_dentry_real(dentry)); - - err = -ETXTBSY; - if (atomic_read(&realinode->i_writecount) < 0) - goto out_drop_write; - /* Truncate should trigger data copy up as well */ full_copy_up = true; } -- 2.27.0
next reply other threads:[~2021-04-24 14:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-24 14:03 Chengguang Xu [this message] 2021-04-24 14:03 ` [RFC PATCH 2/2] ovl: enhance write permission check for writable open Chengguang Xu 2021-07-21 13:14 ` Miklos Szeredi 2021-04-28 12:18 ` 回复:[RFC PATCH 1/2] ovl: skip checking lower file's write permisson on truncate Chengguang Xu 2021-07-20 14:35 ` [RFC " Miklos Szeredi 2021-07-20 15:19 ` Miklos Szeredi 2021-07-20 16:01 ` Chengguang Xu 2021-07-20 16:01 ` Miklos Szeredi 2021-07-20 16:04 ` Chengguang Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210424140316.485444-1-cgxu519@mykernel.net \ --to=cgxu519@mykernel.net \ --cc=linux-unionfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ --subject='Re: [RFC PATCH 1/2] ovl: skip checking lower file'\''s write permisson on truncate' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).