From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chengguang Xu <charliecgxu@tencent.com>
Subject: [RFC PATCH V6 3/7] ovl: implement overlayfs' own ->write_inode operation
Date: Mon, 22 Nov 2021 11:00:34 +0800 [thread overview]
Message-ID: <20211122030038.1938875-4-cgxu519@mykernel.net> (raw)
In-Reply-To: <20211122030038.1938875-1-cgxu519@mykernel.net>
From: Chengguang Xu <charliecgxu@tencent.com>
Sync dirty data and meta of upper inode in overlayfs' ->write_inode()
and redirty overlayfs' inode.
Signed-off-by: Chengguang Xu <charliecgxu@tencent.com>
---
fs/overlayfs/super.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 18a12088a37b..12acf0ec7395 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -15,6 +15,7 @@
#include <linux/seq_file.h>
#include <linux/posix_acl_xattr.h>
#include <linux/exportfs.h>
+#include <linux/writeback.h>
#include "overlayfs.h"
MODULE_AUTHOR("Miklos Szeredi <miklos@szeredi.hu>");
@@ -406,12 +407,32 @@ static int ovl_remount(struct super_block *sb, int *flags, char *data)
return ret;
}
+static int ovl_write_inode(struct inode *inode,
+ struct writeback_control *wbc)
+{
+ struct ovl_fs *ofs = inode->i_sb->s_fs_info;
+ struct inode *upper_inode = ovl_inode_upper(inode);
+ int ret = 0;
+
+ if (!upper_inode)
+ return 0;
+
+ if (!ovl_should_sync(ofs))
+ return 0;
+
+ ret = write_inode_now(upper_inode, wbc->sync_mode == WB_SYNC_ALL);
+ mark_inode_dirty(inode);
+
+ return ret;
+}
+
static const struct super_operations ovl_super_operations = {
.alloc_inode = ovl_alloc_inode,
.free_inode = ovl_free_inode,
.destroy_inode = ovl_destroy_inode,
.drop_inode = generic_delete_inode,
.put_super = ovl_put_super,
+ .write_inode = ovl_write_inode,
.sync_fs = ovl_sync_fs,
.statfs = ovl_statfs,
.show_options = ovl_show_options,
--
2.27.0
next prev parent reply other threads:[~2021-11-22 3:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 3:00 [RFC PATCH V6 0/7] implement containerized syncfs for overlayfs Chengguang Xu
2021-11-22 3:00 ` [RFC PATCH V6 1/7] ovl: setup overlayfs' private bdi Chengguang Xu
2021-11-26 8:51 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper Chengguang Xu
2021-11-26 9:10 ` Jan Kara
2021-11-26 13:06 ` Chengguang Xu
2021-11-26 14:32 ` Jan Kara
2021-11-22 3:00 ` Chengguang Xu [this message]
2021-11-26 9:14 ` [RFC PATCH V6 3/7] ovl: implement overlayfs' own ->write_inode operation Jan Kara
2021-11-26 13:09 ` Chengguang Xu
2021-11-22 3:00 ` [RFC PATCH V6 4/7] ovl: set 'DONTCACHE' flag for overlayfs inode Chengguang Xu
2021-11-26 9:20 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 5/7] fs: export wait_sb_inodes() Chengguang Xu
2021-11-26 9:20 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 6/7] ovl: introduce ovl_sync_upper_blockdev() Chengguang Xu
2021-11-26 9:21 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 7/7] ovl: implement containerized syncfs for overlayfs Chengguang Xu
2021-11-22 7:40 ` Amir Goldstein
2021-11-26 5:03 ` Chengguang Xu
2021-11-26 9:25 ` Jan Kara
2021-11-27 9:26 ` 回复:[RFC PATCH V6 0/7] " Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122030038.1938875-4-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=charliecgxu@tencent.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).