From: Christian Brauner <brauner@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, Seth Forshee <sforshee@kernel.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 23/29] ovl: use posix acl api
Date: Fri, 23 Sep 2022 18:23:17 +0200 [thread overview]
Message-ID: <20220923162317.mvjlv6yzdsvjradl@wittgenstein> (raw)
In-Reply-To: <CAJfpegt1YJzyE=UYF=DNW-qd08zLRgG7vpbm32m0rWEbWjLNOw@mail.gmail.com>
On Fri, Sep 23, 2022 at 05:57:04PM +0200, Miklos Szeredi wrote:
> On Fri, 23 Sept 2022 at 17:47, Christian Brauner <brauner@kernel.org> wrote:
> >
> > On Fri, Sep 23, 2022 at 05:38:34PM +0200, Miklos Szeredi wrote:
>
> > It's basically just like when you copy a file betweed idmapped mounts:
> >
> > mount -o X-mount.idmap=<mapping1> --bind /source /source-idmapped
> > mount -o X-mount.idmap=<mapping2> --bind /target /target-idmapped
> >
> > cp /source-idmapped/file1 /target-idmapped
> >
> > where you need to take the source and target idmappings into account.
> >
> > So basically like what ovl_set_attr() is doing just for acls. But I
>
> But then before this patch the copy-up behavior was incorrect, right?
>
> In that case this needs to be advertised as a bug fix, rather than a cleanup.
No, it was correct. The testsuite I added would've yelled loudly if that
were buggy.
It's just that this was done in vfs_getxattr() before. But that is
rather hacky and is one of the things we're getting rid off. If
vfs_get_acl() did that it would return mount not filesystem values which
isn't correct for the general case.
next prev parent reply other threads:[~2022-09-23 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220922151728.1557914-1-brauner@kernel.org>
2022-09-22 15:17 ` [PATCH 21/29] ovl: implement get acl method Christian Brauner
2022-09-23 14:59 ` Miklos Szeredi
2022-09-23 15:07 ` Christian Brauner
2022-09-22 15:17 ` [PATCH 22/29] ovl: implement set " Christian Brauner
2022-09-23 15:18 ` Miklos Szeredi
2022-09-23 15:35 ` Christian Brauner
2022-09-22 15:17 ` [PATCH 23/29] ovl: use posix acl api Christian Brauner
2022-09-23 15:38 ` Miklos Szeredi
2022-09-23 15:47 ` Christian Brauner
2022-09-23 15:57 ` Miklos Szeredi
2022-09-23 16:23 ` Christian Brauner [this message]
2022-09-22 15:17 ` [PATCH 26/29] ovl: use stub posix acl handlers Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923162317.mvjlv6yzdsvjradl@wittgenstein \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sforshee@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).