From: Christian Brauner <brauner@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
Seth Forshee <sforshee@kernel.org>,
Yang Xu <xuyang2018.jy@fujitsu.com>,
Filipe Manana <fdmanana@kernel.org>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] attr: use consistent sgid stripping checks
Date: Thu, 6 Oct 2022 15:35:32 +0200 [thread overview]
Message-ID: <20221006133532.umwp6gzsh3wujwng@wittgenstein> (raw)
In-Reply-To: <CAJfpegss=79W+BXpOH_n7ZOtci1O0njHHxZMnb8ULJBStkq7mg@mail.gmail.com>
On Thu, Oct 06, 2022 at 03:03:23PM +0200, Miklos Szeredi wrote:
> On Wed, 5 Oct 2022 at 17:14, Christian Brauner <brauner@kernel.org> wrote:
> >
> > Currently setgid stripping in file_remove_privs()'s should_remove_suid()
> > helper is inconsistent with other parts of the vfs. Specifically, it only
> > raises ATTR_KILL_SGID if the inode is S_ISGID and S_IXGRP but not if the
> > inode isn't in the caller's groups and the caller isn't privileged over the
> > inode although we require this already in setattr_prepare() and
> > setattr_copy() and so all filesystem implement this requirement implicitly
> > because they have to use setattr_{prepare,copy}() anyway.
>
> Could the actual code (not just the logic) be shared between
> should_remove_sgid() and setattr_copy()?
>
> Maybe add another helper, or reformulate should_remove_sgid() so that
> it can be used for both purposes.
Yeah, thanks for pointing that out. I'm actually working on that.
next prev parent reply other threads:[~2022-10-06 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 15:14 [PATCH 0/3] fs: improve setgid stripping consistency even more Christian Brauner
2022-10-05 15:14 ` [PATCH 1/3] attr: use consistent sgid stripping checks Christian Brauner
2022-10-05 16:21 ` Amir Goldstein
2022-10-05 21:28 ` Dave Chinner
2022-10-06 7:08 ` Christian Brauner
2022-10-06 13:03 ` Miklos Szeredi
2022-10-06 13:35 ` Christian Brauner [this message]
2022-10-05 15:14 ` [PATCH 2/3] ovl: remove privs in ovl_copyfile() Christian Brauner
2022-10-05 15:14 ` [PATCH 3/3] ovl: remove privs in ovl_fallocate() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006133532.umwp6gzsh3wujwng@wittgenstein \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sforshee@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).