From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13793C7618E for ; Tue, 14 Mar 2023 21:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbjCNVQu (ORCPT ); Tue, 14 Mar 2023 17:16:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbjCNVQt (ORCPT ); Tue, 14 Mar 2023 17:16:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B5A42BD9 for ; Tue, 14 Mar 2023 14:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678828562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l1S6ZGAmfPeeMbczfA0ranezCsJrkelQbLrqGcFpuM0=; b=aJzrJqwNtRhoWO7W9kbCEbr36GOJdG2Q7TUFq1Pr6Yckkx0ypR5LBRQltLVZZjFyksXLfy AaEWdIWPJtA9seXnBRhUnf55Sf+TvaUOm/6VCUwfFzroPOtY8T29VrGINbVJG4mFzl8onW 4iM5uP2B6g4Bx15jmt+yR4vmEu4TOMM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-5WPA3pIjPxuOlksm0f2Vlw-1; Tue, 14 Mar 2023 17:15:59 -0400 X-MC-Unique: 5WPA3pIjPxuOlksm0f2Vlw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 297B71869B6F; Tue, 14 Mar 2023 21:15:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54495400F55; Tue, 14 Mar 2023 21:15:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-3-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miklos Szeredi , Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3771086.1678828554.1@warthog.procyon.org.uk> Date: Tue, 14 Mar 2023 21:15:54 +0000 Message-ID: <3771087.1678828554@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org Christoph Hellwig wrote: > > -static long do_splice_to(struct file *in, loff_t *ppos, > > - struct pipe_inode_info *pipe, size_t len, > > - unsigned int flags) > > +long vfs_splice_read(struct file *in, loff_t *ppos, > > The (pre-existing) long here is odd given that ->splice_read > returns a ssize_t. This might be a good time to fix that up. There's a while lot of places in splice.c that use long rather than ssize_t. I can produce a separate patch that changes them all, but that should perhaps be separate to this. David