From: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
To: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org
Subject: [regression?] escaping commas in overlayfs mount options
Date: Thu, 28 Sep 2023 21:07:47 -0400 (EDT) [thread overview]
Message-ID: <8da307fb-9318-cf78-8a27-ba5c5a0aef6d@alum.mit.edu> (raw)
Up to and including kernel 6.4.15, it was possible to have commas in
the lowerdir/upperdir/workdir paths used by overlayfs, provided they were
escaped with backslashes:
mkdir /tmp/test-lower, /tmp/test-upper /tmp/test-work /tmp/test
mount -t overlay overlay -o 'lowerdir=/tmp/test-lower\,,upperdir=/tmp/test-upper,workdir=/tmp/test-work' /tmp/test
In 6.5.2 and 6.5.5, this no longer works; dmesg reports that overlayfs
can't resolve '/tmp/test-lower' (without the comma).
I see that there is a commit between the 6.4 and 6.5 lines titled [ovl:
port to new mount api][1]. I haven't compiled a kernel before and after
this commit to verify, but based on the code it deletes I strongly suspect
that it, or if not then one of the ovl commits committed on the same day,
is responsible for this change.
[1]: https://github.com/torvalds/linux/commit/1784fbc2ed9c888ea4e895f30a53207ed7ee8208
Does this count as a regression? I can't find documentation for this
escaping feature anywhere, even as it pertains to the non-comma characters
'\\' and ':' (which, I've tested, can still be escaped as expected), so
perhaps it was never properly supported? But a search for escaping commas
in overlayfs turns up resources like [this post][2], suggesting that there
are others who figured this out and expect it to work.
[2]: https://unix.stackexchange.com/a/552640
Is there a new way to escape commas for overlayfs options?
Thanks,
Ryan
next reply other threads:[~2023-09-29 1:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 1:07 Ryan Hendrickson [this message]
2023-09-29 4:44 ` [regression?] escaping commas in overlayfs mount options Amir Goldstein
2023-10-02 22:22 ` Ryan Hendrickson
2023-10-03 9:50 ` Amir Goldstein
2023-10-03 19:07 ` Ryan Hendrickson
2023-10-04 9:03 ` Amir Goldstein
2023-10-06 13:02 ` Sebastian Wick
2023-10-06 16:17 ` Amir Goldstein
2023-10-06 16:42 ` Ryan Hendrickson
2023-10-06 17:21 ` Amir Goldstein
2023-10-10 9:06 ` Miklos Szeredi
2023-10-10 10:00 ` Amir Goldstein
2023-10-10 16:13 ` Sebastian Wick
2023-10-10 16:54 ` Amir Goldstein
2023-10-10 17:33 ` Sebastian Wick
2023-10-10 18:15 ` Amir Goldstein
2023-10-10 18:33 ` Miklos Szeredi
2023-10-11 8:44 ` Amir Goldstein
2023-10-11 10:18 ` Miklos Szeredi
2023-10-11 12:06 ` Amir Goldstein
2023-10-11 13:07 ` Miklos Szeredi
2023-10-11 14:33 ` Miklos Szeredi
2023-10-11 16:37 ` Amir Goldstein
2023-10-11 16:43 ` Amir Goldstein
2023-10-12 8:26 ` Christian Brauner
2023-10-12 9:27 ` Amir Goldstein
2023-10-12 9:49 ` Christian Brauner
2023-10-12 13:54 ` Amir Goldstein
2023-10-12 18:07 ` Sebastian Wick
2023-10-12 8:21 ` Christian Brauner
2023-09-29 5:07 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da307fb-9318-cf78-8a27-ba5c5a0aef6d@alum.mit.edu \
--to=ryan.hendrickson@alum.mit.edu \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).