From: Miklos Szeredi <miklos@szeredi.hu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
overlayfs <linux-unionfs@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ovl: fix missing revert_creds() on error path
Date: Mon, 29 Mar 2021 16:14:33 +0200 [thread overview]
Message-ID: <CAJfpegshpuwp7+SFUX_x6599w+M9vrH2Xn5xRMrRZ6pYf9iUFg@mail.gmail.com> (raw)
In-Reply-To: <YFnq5wHUQgnw4Rga@mwanda>
On Tue, Mar 23, 2021 at 2:19 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Smatch complains about missing that the ovl_override_creds() doesn't
> have a matching revert_creds() if the dentry is disconnected. Fix this
> by moving the ovl_override_creds() until after the disconnected check.
>
> Fixes: aa3ff3c152ff ("ovl: copy up of disconnected dentries")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Miklos
prev parent reply other threads:[~2021-03-29 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:19 [PATCH] ovl: fix missing revert_creds() on error path Dan Carpenter
2021-03-29 14:14 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegshpuwp7+SFUX_x6599w+M9vrH2Xn5xRMrRZ6pYf9iUFg@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).